From: sashiko-bot@kernel.org
To: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
Cc: linux-rt-devel@lists.linux.dev, tj@kernel.org,
hannes@cmpxchg.org, mkoutny@suse.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 27/37] sched/deadline: Keep the last CPU a task has in its root domain
Date: Mon, 16 Nov 2026 19:51:56 +0000 [thread overview]
Message-ID: <sashiko-outbox-217621@kernel.org> (raw)
In-Reply-To: <20261116190549.230119-28-mathieu.desnoyers@efficios.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] sched/deadline: missing affinity masks in
dl_task_leaves_span() fallback
- [Low] sched/deadline: dl_task_leaves_span() rejects CPU offline for
dead tasks
--
commit 48b62790717c3a90940a59e814da93b5ddf9ada9
Author: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
sched/deadline: Keep the last CPU a task has in its root domain
This commit refuses to take a CPU offline with -EBUSY when doing so would
leave a deadline task with runnable CPUs only outside the root domain that
accounts for its bandwidth.
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 5294546786f12..096c0ec55cdc2 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -4896,9 +4896,63 @@ static int dl_bw_manage(enum dl_bw_request req, int cpu, u64 dl_bw)
> return overflow ? -EBUSY : 0;
> }
>
> +/*
> + * Return true if @p has CPUs to run on once @cpu is offline, but none in
> + * the root domain of @cpu, which counts its bandwidth.
> + */
> +static bool dl_task_leaves_span(struct task_struct *p, int cpu,
> + const struct cpumask *span)
> +{
> + struct cpumask *msk;
> +
> + guard(raw_spinlock_irqsave)(&p->pi_lock);
> + if (dl_task_bw_span(p) != span)
> + return false;
> + msk = this_cpu_cpumask_var_ptr(local_cpu_mask_dl);
> + cpumask_and(msk, p->cpus_ptr, cpu_active_mask);
> + cpumask_clear_cpu(cpu, msk);
> + /* With no CPU left, the cpuset gives @p the CPUs of an ancestor. */
> + if (cpumask_empty(msk))
> + cpuset_cpus_allowed_without(p, cpu, msk);
> + return !cpumask_empty(msk) && !cpumask_intersects(msk, span);
> +}
[Severity: Medium]
When msk is empty and dl_task_leaves_span() falls back to
cpuset_cpus_allowed_without(), does it also need to restrict the inherited
ancestor mask by p->user_cpus_ptr (when their intersection is non-empty)
and task_cpu_possible_mask(p)?
When the CPU goes offline, cpuset_update_tasks_cpumask() updates the task
via __set_cpus_allowed_ptr(), which intersects the new cpuset mask with
p->user_cpus_ptr if they overlap:
kernel/sched/core.c:__set_cpus_allowed_ptr() {
...
if (p->user_cpus_ptr &&
!(ctx->flags & (SCA_USER | SCA_MIGRATE_ENABLE | SCA_MIGRATE_DISABLE)) &&
cpumask_and(rq->scratch_mask, ctx->new_mask, p->user_cpus_ptr))
ctx->new_mask = rq->scratch_mask;
...
}
Suppose CPUs 0-1 are housekeeping CPUs in span and CPUs 2-3 are isolated
(isolcpus=domain,2,3), and a task with user_cpus_ptr = {0, 2, 3} is moved
into a child cpuset with cpuset.cpus = 0 under top_cpuset (0-3). Taking
CPU 0 offline leaves msk empty, so cpuset_cpus_allowed_without() returns
{1, 2, 3} from top_cpuset. Because dl_task_leaves_span() sees CPU 1 in
msk & span, it allows the offline, after which __set_cpus_allowed_ptr()
intersects {1, 2, 3} with user_cpus_ptr and restricts the task to {2, 3} in
the default root domain without an admission check.
In addition, the CONFIG_CPUSETS implementation of
cpuset_cpus_allowed_without() does not intersect cs->effective_cpus with
task_cpu_possible_mask(tsk), unlike guarantee_active_cpus() and the
!CONFIG_CPUSETS stub.
> +
> +/*
> + * Return true if @cpu is the last CPU that a deadline task can run on in
> + * the root domain that counts its bandwidth. With @cpu offline, the task
> + * would run in another root domain, which did not admit it. The mask of
> + * a task holds CPUs of two root domains only with isolcpus="domain".
> + *
> + * A suspend takes the CPUs offline with the tasks frozen, and the resume
> + * puts them back. Without admission control, there is no limit to exceed.
> + * Return false in both cases.
> + */
> +static bool dl_cpu_last_of_task(int cpu)
> +{
> + const struct cpumask *span;
> + struct task_struct *g, *p;
> +
> + if (cpuhp_tasks_frozen || !dl_bandwidth_enabled())
> + return false;
> + /* No task holds a bandwidth: do not walk the task list. */
> + if (!atomic_read(&dl_nr_bw_tasks))
> + return false;
> + guard(rcu)();
> + span = cpu_rq(cpu)->rd->span;
> + for_each_process_thread(g, p) {
> + if (task_has_dl_policy(p) && dl_task_leaves_span(p, cpu, span))
> + return true;
> + }
[Severity: Low]
Can this reject a CPU offline when p is an un-reaped exited task waiting for
its 0-lag timer?
When a deadline task exits before its 0-lag time, task_non_contending()
places it on dl_departed_list and arms inactive_timer while leaving
p->policy and p->dl.dl_bw_cpu set. Until release_task() unhashes the task
or inactive_timer fires, for_each_process_thread() still visits it and
dl_task_leaves_span() returns true if the outgoing CPU was its only CPU in
span, causing dl_bw_deactivate() to fail with -EBUSY even though a
TASK_DEAD task will never run again or move its bandwidth to another root
domain.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116190549.230119-1-mathieu.desnoyers@efficios.com?part=27
next prev parent reply other threads:[~2026-11-16 19:51 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 19:05 [PATCH v6 00/37] sched/deadline: bandwidth accounting fixes and selftests Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 01/37] sched: Refuse SCHED_FLAG_KEEP_PARAMS that would change the policy or the class Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 02/37] sched/deadline: Do not admit bandwidth for parameters that are kept Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 03/37] sched: Let a task boosted by a deadline waiter change its policy Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 04/37] sched/deadline: Do not divide by zero active CPUs of a root domain Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 05/37] sched/deadline: Refuse dl_server debugfs writes while the rq is offline Mathieu Desnoyers
2026-11-16 19:30 ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 06/37] sched: Take cpuset_mutex for a deadline policy change only with pi Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 07/37] sched/deadline: Do not lose a throttled task switched out and back Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 08/37] sched/deadline: Do not replenish a boost from cleared parameters Mathieu Desnoyers
2026-11-16 19:42 ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 09/37] sched/deadline: Reset the deadline and the runtime with the parameters Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 10/37] sched/deadline: Reset the donor's runtime at a deboost in the class Mathieu Desnoyers
2026-11-16 19:38 ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 11/37] sched/deadline: Release the bandwidth of a task that leaves the class asleep Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 12/37] sched/deadline: Reject SCHED_DEADLINE on exited tasks Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 13/37] sched/deadline: Keep departing bandwidth across a root domain rebuild Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 14/37] sched/deadline: Fix this_bw when a task is changed during a remote wakeup Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 15/37] sched/deadline: Rebuild the root domains' accounting from the task list Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 16/37] sched/deadline: Record the root domain holding a task's bandwidth Mathieu Desnoyers
2026-11-16 19:44 ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 17/37] sched/deadline: Leave a dying task out of a rebuild of the accounting Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 18/37] sched/deadline: Check SCHED_DEADLINE affinity under the rq lock Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 19/37] sched/deadline: Move a task's bandwidth only where room was made Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 20/37] cgroup/cpuset: Wait for an attach before rebuilding the sched domains Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 21/37] sched: Make deadline policy and affinity changes wait for a cpuset attach Mathieu Desnoyers
2026-11-16 19:31 ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 22/37] cgroup/cpuset: Give back the bandwidth an attach did not move Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 23/37] cgroup/cpuset: Reserve the bandwidth in the root domain a task moves to Mathieu Desnoyers
2026-11-16 19:56 ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 24/37] sched/deadline: Make a rebuild count a task in the root domain it runs in Mathieu Desnoyers
2026-11-16 20:01 ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 25/37] sched/deadline: Move a task's bandwidth to " Mathieu Desnoyers
2026-11-16 19:47 ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 26/37] sched/deadline: Keep a task in the root domain that counts its bandwidth Mathieu Desnoyers
2026-11-16 19:50 ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 27/37] sched/deadline: Keep the last CPU a task has in its root domain Mathieu Desnoyers
2026-11-16 19:51 ` sashiko-bot [this message]
2026-11-16 19:05 ` [PATCH v6 28/37] cgroup/cpuset: Refuse to take a deadline task out of " Mathieu Desnoyers
2026-11-16 20:08 ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 29/37] sched/deadline: Cancel the replenishment timer with the parameters Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 30/37] sched/deadline: Count the bandwidth a boosted task is given Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 31/37] sched/deadline: Start a period for a task that enters the class blocked Mathieu Desnoyers
2026-11-16 20:12 ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 32/37] sched/deadline: Check the runtime of a task that comes back runnable Mathieu Desnoyers
2026-11-16 20:08 ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 33/37] sched/deadline: Check the runtime of a task whose parameters change Mathieu Desnoyers
2026-11-16 20:04 ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 34/37] sched/debug: Show the deadline bandwidth of each runqueue Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 35/37] selftests/sched: Add a test of SCHED_DEADLINE policy round trips Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 36/37] selftests/sched: Test SCHED_DEADLINE bandwidth across a root domain rebuild Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 37/37] selftests/sched: Add a test of SCHED_DEADLINE bandwidth accounting Mathieu Desnoyers
2026-11-16 19:49 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-217621@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=mathieu.desnoyers@efficios.com \
--cc=mkoutny@suse.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox