Linux real-time development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
Cc: linux-rt-devel@lists.linux.dev, tj@kernel.org,
	hannes@cmpxchg.org, mkoutny@suse.com,
	linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v4 10/17] sched/deadline: Fix an overflow of the 0-lag time with long periods
Date: Thu, 19 Nov 2026 16:46:47 +0000	[thread overview]
Message-ID: <sashiko-outbox-223567@kernel.org> (raw)
In-Reply-To: <abbad2aa0ec392b1b0ede00b66b2d177d2b7b2df.1795105408.git.mathieu.desnoyers@efficios.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] sched/deadline: unguarded overrun division in
  task_non_contending()
--

commit d4e10a0b92da9c2b0b15604d4fa7ca96de8eadaf
Author: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

sched/deadline: Fix an overflow of the 0-lag time with long periods

This commit uses mul_u64_u64_div_u64() to compute the 0-lag time in
task_non_contending() so that runtime * dl_period does not overflow s64
with long periods, and bounds the positive-runtime division when the
parameters were shrunk.

> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index d6d2657dcddd6..5e4aff28e9bcd 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -411,7 +411,7 @@ static void task_non_contending(struct sched_dl_entity *dl_se, bool dl_task)
>  	struct hrtimer *timer = &dl_se->inactive_timer;
>  	struct rq *rq = rq_of_dl_se(dl_se);
>  	struct dl_rq *dl_rq = &rq->dl;
> -	s64 zerolag_time;
> +	s64 zerolag_time, left;
>  
>  	/*
>  	 * If this is a non-deadline task that has been boosted,
> @@ -425,15 +425,40 @@ static void task_non_contending(struct sched_dl_entity *dl_se, bool dl_task)
>  
>  	WARN_ON(dl_se->dl_non_contending);
>  
> -	zerolag_time = dl_se->deadline -
> -		 div64_long((dl_se->runtime * dl_se->dl_period),
> -			dl_se->dl_runtime);
> -
>  	/*
> -	 * Using relative times instead of the absolute "0-lag time"
> -	 * allows to simplify the code
> +	 * The 0-lag time is the deadline minus the runtime left, scaled by
> +	 * dl_period / dl_runtime. The product of the runtime and dl_period
> +	 * can overflow s64 with periods of a few seconds, so multiply on 128
> +	 * bits. Compute the 0-lag time relative to now.
> +	 *
> +	 * After a change of parameters, the runtime and the deadline stay
> +	 * those of the old parameters until the next period. The 0-lag time
> +	 * uses the new dl_runtime and dl_period. The runtime left can then be
> +	 * far above dl_runtime, and the quotient too large for 64 bits. So
> +	 * first compare the runtime left with the runtime that the new
> +	 * parameters give until the deadline:
> +	 *
> +	 *   (deadline - now) * dl_runtime / dl_period
> +	 *
> +	 * If it is larger, the 0-lag time has passed, and the bandwidth is
> +	 * released now.
> +	 *
> +	 * The runtime is negative after an overrun. The next tick throttles
> +	 * the task, so the overrun is short and its quotient fits.
>  	 */
> -	zerolag_time -= rq_clock(rq);
> +	left = dl_se->deadline - rq_clock(rq);
> +	if (dl_se->runtime < 0)
> +		zerolag_time = left +
> +			mul_u64_u64_div_u64(-dl_se->runtime, dl_se->dl_period,
> +					    dl_se->dl_runtime);

[Severity: Medium]
Can mul_u64_u64_div_u64() in the dl_se->runtime < 0 branch still overflow
s64 or u64 when dl_runtime was shrunk or the overrun spans multiple
seconds?

An overrun is not guaranteed to be short: in a guest, a vCPU preemption
can produce a multi-second delta_exec in a single update_curr_dl_se()
call, and a task throttled while blocking on an rt_mutex that is then
PI-boosted before waking has dl_throttled cleared in enqueue_task_dl()
without replenishment (because dl_entity_overflow() returns false when
dl_se->runtime < 0).

If a task with a raised period limit (e.g. 300s or UINT_MAX us) shrinks
dl_runtime to 1024 ns via sched_setattr(), an overrun of a few seconds
makes (-dl_se->runtime * dl_se->dl_period) / dl_se->dl_runtime exceed
S64_MAX (wrapping zerolag_time negative and releasing bandwidth early) or
U64_MAX (trapping with #DE in divq on x86-64). Even with the default 4s
period limit, scaling a single-tick overrun of the old runtime by the new
dl_period / dl_runtime ratio can arm inactive_timer for hours, locking up
running_bw and total_bw.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1795105408.git.mathieu.desnoyers@efficios.com?part=10

  reply	other threads:[~2026-11-19 16:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 16:24 [RESEND PATCH v4 00/17] sched/deadline: first bandwidth accounting fixes and selftests Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 01/17] sched: Refuse SCHED_FLAG_KEEP_PARAMS that would change the policy or the class Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 02/17] sched/deadline: Do not admit bandwidth for parameters that are kept Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 03/17] sched: Let a task boosted by a deadline waiter change its policy Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 04/17] sched/deadline: Do not divide by zero active CPUs of a root domain Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 05/17] sched/deadline: Refuse dl_server debugfs writes while the rq is offline Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 06/17] sched: Take cpuset_mutex for a deadline policy change only with pi Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 07/17] sched/deadline: Do not lose a throttled task switched out and back Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 08/17] sched/deadline: Do not replenish a boost from cleared parameters Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 09/17] sched/deadline: Reset the deadline and the runtime with the parameters Mathieu Desnoyers
2026-11-19 16:49   ` sashiko-bot
2026-11-19 16:24 ` [RESEND PATCH v4 10/17] sched/deadline: Fix an overflow of the 0-lag time with long periods Mathieu Desnoyers
2026-11-19 16:46   ` sashiko-bot [this message]
2026-11-19 18:14     ` Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 11/17] sched/deadline: Release the bandwidth of a task that leaves the class asleep Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 12/17] sched/deadline: Reject SCHED_DEADLINE on exited tasks Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 13/17] sched/deadline: Fix this_bw when a task is changed during a remote wakeup Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 14/17] sched/deadline: Check SCHED_DEADLINE affinity under the rq lock Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 15/17] sched/debug: Show the deadline bandwidth of each runqueue Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 16/17] selftests/sched: Add a test of SCHED_DEADLINE policy round trips Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 17/17] selftests/sched: Add a test of SCHED_DEADLINE bandwidth accounting Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223567@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mkoutny@suse.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox