From: John Kacur <jkacur@redhat.com>
To: rostedt@goodmis.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
lkml <linux-kernel@vger.kernel.org>,
rt-users <linux-rt-users@vger.kernel.org>,
Clark Williams <williams@redhat.com>
Subject: Re: [PATCH 2/2] rt: Remove CONFIG_STACK_TRACER from DEBUG_COUNT
Date: Wed, 24 Mar 2010 15:27:28 -0400 (EDT) [thread overview]
Message-ID: <1088471101.823551269458848070.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com> (raw)
In-Reply-To: <1269454428.2957.2890.camel@gandalf.stny.rr.com>
----- "Steven Rostedt" <rostedt@goodmis.org> wrote:
> On Wed, 2010-03-24 at 18:35 +0100, John Kacur wrote:
> > Remove CONFIG_STACK_TRACER from DEBUG_COUNT so that reminder
> messages
> > are printed correctly, and don't leave an empty reminder block for
> example.
> >
>
> I think this should be attached to patch 1. Why have two patches for
> this?
Because patch 1 is a revert, I thought this makes the git history cleaner.
John
>
> -- Steve
>
> > Signed-off-by: John Kacur <jkacur@redhat.com>
> > ---
> > init/main.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/init/main.c b/init/main.c
> > index aa48b7b..17fd973 100644
> > --- a/init/main.c
> > +++ b/init/main.c
> > @@ -908,7 +908,7 @@ static int __init kernel_init(void * unused)
> > WARN_ON(irqs_disabled());
> > #endif
> >
> > -#define DEBUG_COUNT (defined(CONFIG_DEBUG_RT_MUTEXES) +
> defined(CONFIG_IRQSOFF_TRACER) + defined(CONFIG_PREEMPT_TRACER) +
> defined(CONFIG_STACK_TRACER) + defined(CONFIG_INTERRUPT_OFF_HIST) +
> defined(CONFIG_PREEMPT_OFF_HIST) + defined(CONFIG_WAKEUP_LATENCY_HIST)
> + defined(CONFIG_DEBUG_SLAB) + defined(CONFIG_DEBUG_PAGEALLOC) +
> defined(CONFIG_LOCKDEP) + (defined(CONFIG_FTRACE) -
> defined(CONFIG_FTRACE_MCOUNT_RECORD)))
> > +#define DEBUG_COUNT (defined(CONFIG_DEBUG_RT_MUTEXES) +
> defined(CONFIG_IRQSOFF_TRACER) + defined(CONFIG_PREEMPT_TRACER) +
> defined(CONFIG_INTERRUPT_OFF_HIST) + defined(CONFIG_PREEMPT_OFF_HIST)
> + defined(CONFIG_WAKEUP_LATENCY_HIST) + defined(CONFIG_DEBUG_SLAB) +
> defined(CONFIG_DEBUG_PAGEALLOC) + defined(CONFIG_LOCKDEP) +
> (defined(CONFIG_FTRACE) - defined(CONFIG_FTRACE_MCOUNT_RECORD)))
> >
> > #if DEBUG_COUNT > 0
> > printk(KERN_ERR
> "*****************************************************************************\n");
prev parent reply other threads:[~2010-03-24 20:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 17:35 [PATCH 0/2] [rt-kernel] John Kacur
2010-03-24 17:35 ` [PATCH 1/2] Revert "rt: trivial fix to REMINDER block in init/main.c" John Kacur
2010-03-24 18:13 ` Steven Rostedt
2010-03-24 17:35 ` [PATCH 2/2] rt: Remove CONFIG_STACK_TRACER from DEBUG_COUNT John Kacur
2010-03-24 18:13 ` Steven Rostedt
2010-03-24 19:27 ` John Kacur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1088471101.823551269458848070.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com \
--to=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).