linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@mvista.com>
To: Leon Woestenberg <leon.woestenberg@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	RT <linux-rt-users@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	leon@sidebranch.com
Subject: Re: [PATCH -rt] [resend as inlined patch] {queue,schedule}_work_prio() allowing work priorities other than caller's priority
Date: Fri, 04 Jul 2008 10:41:20 -0700	[thread overview]
Message-ID: <1215193280.9513.3.camel@localhost.localdomain> (raw)
In-Reply-To: <486E271E.705@sidebranch.com>


On Fri, 2008-07-04 at 15:35 +0200, Leon Woestenberg wrote:

> Index: linux-2.6.24/kernel/workqueue.c
> ===================================================================
> --- linux-2.6.24.orig/kernel/workqueue.c    2008-06-30 
> 17:12:05.000000000 +0200
> +++ linux-2.6.24/kernel/workqueue.c    2008-06-30 17:25:03.000000000 +0200
> @@ -163,9 +163,10 @@
>  }
>  
>  /**
> - * queue_work - queue work on a workqueue
> + * queue_work_prio - queue work on a workqueue and set work priority
>   * @wq: workqueue to use
>   * @work: work to queue
> + * @prio: priority of work
>   *
>   * Returns 0 if @work was already on a queue, non-zero otherwise.
>   *
> @@ -174,17 +175,36 @@
>   *
>   * Especially no such guarantee on PREEMPT_RT.
>   */
> -int fastcall queue_work(struct workqueue_struct *wq, struct work_struct 
> *work)
> +int fastcall queue_work_prio(struct workqueue_struct *wq,
> +  struct work_struct *work, int prio)

Looks like you patch has line wrapped damage, and white space damage..
If your cutting an pasting the patches that will usually remove the
white space (which we don't want), and often mailers will line wrap if
you don't specify that it's formatted already.

Daniel


  reply	other threads:[~2008-07-04 17:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-04 13:35 [PATCH -rt] [resend as inlined patch] {queue,schedule}_work_prio() allowing work priorities other than caller's priority Leon Woestenberg
2008-07-04 17:41 ` Daniel Walker [this message]
2008-07-05 14:07   ` Leon Woestenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1215193280.9513.3.camel@localhost.localdomain \
    --to=dwalker@mvista.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=leon.woestenberg@gmail.com \
    --cc=leon@sidebranch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).