From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH 1/3] powerpc - Initialize the irq radix tree earlier Date: Tue, 05 Aug 2008 11:05:03 +1000 Message-ID: <1217898303.24157.122.camel@pasglop> References: <1217848124-3719-1-git-send-email-sebastien.dugue@bull.net> <1217848124-3719-2-git-send-email-sebastien.dugue@bull.net> <1217898226.24157.120.camel@pasglop> Reply-To: benh@kernel.crashing.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: tinytim@us.ibm.com, linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, jean-pierre.dion@bull.net, linuxppc-dev@ozlabs.org, paulus@samba.org, gilles.carry@ext.bull.net, tglx@linutronix.de To: Sebastien Dugue Return-path: In-Reply-To: <1217898226.24157.120.camel@pasglop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org List-Id: linux-rt-users.vger.kernel.org > - Remove the populating of the tree from the revmap function as > you already do > - Move it to irq_create_mapping() for the normal case > - For pre-existing interrupt, have the generic code that initializes > the radix tree walk through all interrupts and setup the revmap for > them. If that needs locking vs. concurrent irq_create_mapping, it's > easy to use one of the available spinlocks for that. And in fact, you may even be able to avoid GFP_ATOMIC completely here and switch it to GFP_KERNEL since irq_create_mapping() can sleep afaik, provided that you avoid the spinlocking. Ben.