From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH 2/2] powerpc - Make the irq reverse mapping radix tree lockless Date: Thu, 04 Sep 2008 17:34:03 +1000 Message-ID: <1220513643.4879.68.camel@pasglop> References: <1218029429-21114-1-git-send-email-sebastien.dugue@bull.net> <1218029429-21114-3-git-send-email-sebastien.dugue@bull.net> <1219209781.21386.25.camel@pasglop> <20080903154105.7dff49db@bull.net> <1220496739.4879.20.camel@pasglop> <20080904092252.12b3df4a@bull.net> Reply-To: benh@kernel.crashing.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: dwalker@mvista.com, tinytim@us.ibm.com, linux-rt-users@vger.kernel.org, jean-pierre.dion@bull.net, rostedt@goodmis.org, linux-kernel@vger.kernel.org, michael@ellerman.id.au, linuxppc-dev@ozlabs.org, paulus@samba.org, gilles.carry@ext.bull.net, tglx@linutronix.de To: Sebastien Dugue Return-path: In-Reply-To: <20080904092252.12b3df4a@bull.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org List-Id: linux-rt-users.vger.kernel.org > > > I could not think of anything simple so far and I'm open for suggestions. > > > > GFP_KERNEL should not fail, it will just block no ? > > No it won't block and will fail (returns NULL). hrm... it used to never fail.. that may have changed. But it will definitely block and try very hard to push things out to make space, which is the whole point :-) > I will have to add that back as there is no more fallback. Well, the must be one in the case the tree isn't initialized yet, so if there's an allocation failure, you may "de-initialize" it or something... Or you can fallback if you don't find, as easy, probably easier since it shouldn't happen in practice. > > I don't know if it's worth trying to fire off a new > > allocation attempt later, probably not. > > I've been pondering with this lately, but I think that adding a linear > lookup fallback should be OK. Yup. Cheers, Ben.