linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Jean Delvare <khali@linux-fr.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Leon Woestenberg <leon.woestenberg@gmail.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Sven-Thorsten Dietrich <sven@thebigcorporation.com>,
	linux-i2c@vger.kernel.org,
	rt-users <linux-rt-users@vger.kernel.org>,
	"Ben Dooks (embedded platforms)" <ben-linux@fluff.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: yield() in i2c non-happy paths hits BUG under -rt patch
Date: Thu, 19 Nov 2009 14:18:40 +0100	[thread overview]
Message-ID: <1258636720.4372.350.camel@twins> (raw)
In-Reply-To: <20091119130526.23a69b85@hyperion.delvare>

On Thu, 2009-11-19 at 13:05 +0100, Jean Delvare wrote:
> 
> Was yield() turned into NOOP by design, or was it a bug?

Design.

yield() for SCHED_OTHER is not specified, so everything goes.

There's two possible 'sane' options for yield for (CFS's) SCHED_OTHER:

 - place the task behind all other tasks of the same nice level

   This is however an O(n) operation for CFS since we don't separate
   things out based on nice level, hence we don't do that.

 - service the task that is most starved of service

   That fits nicely into the fairness thing, and is what we default to.
   The thing is, that's current in 99% of the cases, otherwise we would
   already be running another task.

   So its not strictly a NOP, but in practice it is.


There is also another option, place the task behind _all_ other tasks,
but that also surprises people and causes regressions, because they
don't expect yield() to wait _that_ long.


And all this is irrespective of the question of whether yield() is ever
a sane thing to do (I say not).

  parent reply	other threads:[~2009-11-19 13:17 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-07 19:01 yield() in i2c non-happy paths hits BUG under -rt patch Leon Woestenberg
     [not found] ` <c384c5ea0911071101u7415d37o2611c542e5fae309-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-11-07 20:01   ` Jean Delvare
     [not found]     ` <20091107210147.3e754278-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-11-08 18:57       ` Sven-Thorsten Dietrich
     [not found]         ` <4AF7148C.9090706-IsH+rWyeNGyzjR9+/8zPv5owlv4uC7bZ@public.gmane.org>
2009-11-12 20:12           ` Jean Delvare
2009-11-13 22:03             ` Thomas Gleixner
2009-11-14 18:02               ` Jean Delvare
     [not found]               ` <alpine.LFD.2.00.0911132139560.24119-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-11-16 15:56                 ` Mark Brown
     [not found]                   ` <20091116155606.GC29479-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2009-11-18  0:50                     ` Leon Woestenberg
2009-11-18  1:05                       ` Alan Cox
     [not found]                         ` <20091118010520.4cd397d4-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
2009-11-18 16:28                           ` Leon Woestenberg
2009-11-18 16:52                             ` Jean Delvare
     [not found]                               ` <20091118175202.490989d8-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-11-18 20:36                                 ` Thomas Gleixner
2009-11-19 12:05                                   ` Jean Delvare
     [not found]                                     ` <20091119130526.23a69b85-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-11-19 12:59                                       ` Alan Cox
     [not found]                                         ` <20091119125906.6ad00edd-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
2009-11-19 13:06                                           ` Peter Zijlstra
2009-11-19 14:00                                             ` Jean Delvare
2009-11-19 14:15                                               ` Peter Zijlstra
2009-11-19 13:11                                       ` Thomas Gleixner
2009-11-19 13:21                                         ` Peter Zijlstra
2009-11-19 13:22                                           ` Thomas Gleixner
2009-11-19 13:18                                     ` Peter Zijlstra [this message]
2009-11-18 20:46                               ` [PATCH] cleanup sched_yield (sys)call nesting Sven-Thorsten Dietrich
     [not found]                                 ` <1258577194.12429.86.camel-ZUMNgey8dAdBci4yedNfAfz91O0DMRRp0E9HWUfgJXw@public.gmane.org>
2009-11-18 20:56                                   ` Thomas Gleixner
     [not found]                                     ` <alpine.LFD.2.00.0911182153010.24119-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-11-18 21:04                                       ` Sven-Thorsten Dietrich
2009-11-18 21:34                                         ` Thomas Gleixner
     [not found]                                           ` <alpine.LFD.2.00.0911182233510.24119-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-11-19  4:48                                             ` Sven-Thorsten Dietrich
     [not found]                                               ` <1258606116.25022.57.camel-ZUMNgey8dAdBci4yedNfAfz91O0DMRRp0E9HWUfgJXw@public.gmane.org>
2009-11-19 10:36                                                 ` Thomas Gleixner
2009-11-19  3:20                                   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258636720.4372.350.camel@twins \
    --to=peterz@infradead.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=ben-linux@fluff.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=khali@linux-fr.org \
    --cc=leon.woestenberg@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=sven@thebigcorporation.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).