From: john stultz <johnstul@us.ibm.com>
To: Thomas Gleixner <tglx@linutronix.de>, linux-rt-users@vger.kernel.org
Cc: Clark Williams <williams@redhat.com>, Darren Hart <dvhltc@us.ibm.com>
Subject: [PATCH 1/2] Fix mnt_count typo
Date: Wed, 12 May 2010 17:45:44 -0700 [thread overview]
Message-ID: <1273711544.2856.15.camel@localhost.localdomain> (raw)
Clark noticed the following snippit in commit
070976b5b038218900648ea4cc88786d5dfcd58d :
if (mnt->mnt_pinned) {
- inc_mnt_count(mnt);
+ preempt_disable();
+ dec_mnt_count(mnt);
+ preempt_enable();
mnt->mnt_pinned--;
}
vfsmount_write_unlock();
I accidentally replaced an inc_mnt_count() with a dec_mnt_count().
The issue went unnoticed, as the only user of mnt_unpin in the acct
syscall.
This patch corrects the mistake.
Signed-off-by: John Stultz <johnstul@us.ibm.com>
diff --git a/fs/namespace.c b/fs/namespace.c
index 35c56c2..ed4a3ea 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -825,7 +825,7 @@ void mnt_unpin(struct vfsmount *mnt)
vfsmount_write_lock();
if (mnt->mnt_pinned) {
preempt_disable();
- dec_mnt_count(mnt);
+ inc_mnt_count(mnt);
preempt_enable();
mnt->mnt_pinned--;
}
next reply other threads:[~2010-05-13 0:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 0:45 john stultz [this message]
2010-05-13 0:52 ` [PATCH 2/2] Resolve mntput_no_expire issues john stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273711544.2856.15.camel@localhost.localdomain \
--to=johnstul@us.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).