From: john stultz <johnstul@us.ibm.com>
To: Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
rt-users <linux-rt-users@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Nick Piggin <npiggin@suse.de>
Subject: Re: 2.6.33.5 rt23: sleeping function called from invalid context
Date: Thu, 08 Jul 2010 18:44:32 -0700 [thread overview]
Message-ID: <1278639872.3008.36.camel@localhost.localdomain> (raw)
In-Reply-To: <1278610624.3008.2.camel@localhost.localdomain>
On Thu, 2010-07-08 at 10:37 -0700, john stultz wrote:
> On Wed, 2010-07-07 at 20:54 -0700, Fernando Lopez-Lezcano wrote:
> > After a suspend/wake up cycle, just after upgrading to fc12 (I did not
> > see this with the same basic kernel - that is, compiled from the same
> > source + patches - under fc11).
> >
> > BUG: sleeping function called from invalid context at
> > kernel/rtmutex.c:684
> > pcnt: 0 0 in_atomic(): 0, irqs_disabled(): 1, pid: 10582, name:
> > pm-suspend
> > Pid: 10582, comm: pm-suspend Not tainted
> > 2.6.33.5-120.rt23.1.fc11.ccrma.i686.rtPAE #1
> > Call Trace:
> > [<c042eced>] __might_sleep+0xcc/0xd4
> > [<c0464f57>] rt_spin_lock_fastlock.clone.1+0x26/0x5f
> > [<c0792862>] rt_spin_lock+0x8/0xa
> > [<c040dddc>] read_persistent_clock+0x11/0x30
> > [<c045d1de>] timekeeping_suspend+0xe/0x4e
> > [<c0640c9e>] sysdev_suspend+0x15c/0x356
> > [<c0792906>] ? _mutex_unlock+0x8/0xa
> > [<c046afc1>] suspend_devices_and_enter+0xea/0x17f
>
> Huh. Looks like the lock protecting the RTC/CMOS might need to be
> converted to a raw spinlock, since suspend/resume is probably done with
> irqs off.
Oof. The rtc_lock is used all over the place. Not sure if we really want
to convert it to a raw_spinlock.
However, sysdev_suspend() wants interrupts off on all the .suspend
calls. I'm surprised we haven't hit this issue with more drivers. Maybe
no one is testing suspend w/ -rt? Or am I just missing an obvious
solution?
Thomas, any thoughts on this?
thanks
-john
next prev parent reply other threads:[~2010-07-09 1:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 3:54 2.6.33.5 rt23: sleeping function called from invalid context Fernando Lopez-Lezcano
2010-07-08 17:37 ` john stultz
2010-07-08 17:49 ` Fernando Lopez-Lezcano
2010-07-09 1:44 ` john stultz [this message]
2010-07-14 22:06 ` Fernando Lopez-Lezcano
2010-07-14 22:12 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278639872.3008.36.camel@localhost.localdomain \
--to=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=nando@ccrma.Stanford.EDU \
--cc=npiggin@suse.de \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).