From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Galbraith Subject: Re: [PATCH 2/2] Compile error with allmodconfig and CONFIG_PREEMPT_RT_FULL=y Date: Wed, 16 Nov 2011 15:21:45 +0100 Message-ID: <1321453305.15820.25.camel@marge.simson.net> References: <1321235083-21756-1-git-send-email-jkacur@redhat.com> <1321235083-21756-2-git-send-email-jkacur@redhat.com> <20111114165148.GB2372@linux.vnet.ibm.com> <1321303871.5011.6.camel@frodo> <1321334539.6347.43.camel@marge.simson.net> <1321359802.4181.1.camel@frodo> <1321363643.9105.13.camel@marge.simson.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: John Kacur , "Paul E. McKenney" , Thomas Gleixner , lkml , rt-users To: Steven Rostedt Return-path: Received: from mailout-de.gmx.net ([213.165.64.22]:42976 "HELO mailout-de.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1757766Ab1KPOVu (ORCPT ); Wed, 16 Nov 2011 09:21:50 -0500 In-Reply-To: <1321363643.9105.13.camel@marge.simson.net> Sender: linux-rt-users-owner@vger.kernel.org List-ID: On Tue, 2011-11-15 at 14:27 +0100, Mike Galbraith wrote: > On Tue, 2011-11-15 at 07:23 -0500, Steven Rostedt wrote: > > > Right, migrate_disable() should not have been an EXPORT_SYMBOL_GPL(), as > > it is a helper functions that is also exported as EXPORT_SYMBOL(). It > > shouldn't be called directly anyway, even by code in the kernel proper. > > Ah. Doesn't matter though. I downloaded their latest, tried to build > it with EXPORT_SYMBOL(migrate_enable/disable) .. > > FATAL: modpost: GPL-incompatible module nvidia.ko uses GPL-only symbol '__rt_mutex_init' > > With that exported, the thing builds and runs, but rt_mutex_foo exports > appear to be intentionally GPL only, so it's "go fish" for nVidia. Bah. I checked the crusty old hack for crusty old driver, and it still works just fine with a trivial define. It'd probably work better if it didn't need cheezy raw_* hacks, but then it'd probably work better if it was GPL too ;-) -Mike