From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: 3.2-rc1 and nvidia drivers Date: Wed, 30 Nov 2011 08:34:45 -0500 Message-ID: <1322660085.17003.112.camel@frodo> References: <4EC384FD.1040106@tum.de> <4ED35D9A.7090401@tum.de> <1322620613.17003.110.camel@frodo> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Thomas Schauss , Thomas Gleixner , RT , Peter Zijlstra To: John Kacur Return-path: Received: from hrndva-omtalb.mail.rr.com ([71.74.56.124]:39468 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754109Ab1K3Neu (ORCPT ); Wed, 30 Nov 2011 08:34:50 -0500 In-Reply-To: Sender: linux-rt-users-owner@vger.kernel.org List-ID: On Wed, 2011-11-30 at 09:23 +0100, John Kacur wrote: > Steve - I'm aware that this is a false positive, I discussed this with > Peter already. Normally I don't like the idea of changing code for a > tool, but if you see the comment that they wrote above where I put the > unlock - it was an extraordinary thing NOT to drop the lock here, as > slab_destroy is normally called without it. It doesn't seem like good > form to me to hold a lock longer than you need it, and it is a simple > solution to getting rid of the lockdep splat. (false positive, or > false negative, depending on how you see it.) That being said, I'm not > adverse to another solution either, but this one should work and is > simple. This is a mainline issue, and it should go there. If mainline accepts it, then fine. Otherwise, it's not going to go into -rt. -- Steve