From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: [ANNOUNCE] 3.2.9-rt17
Date: Thu, 08 Mar 2012 21:08:23 +0100 [thread overview]
Message-ID: <1331237303.11248.413.camel@twins> (raw)
In-Reply-To: <1331236900.25686.462.camel@gandalf.stny.rr.com>
On Thu, 2012-03-08 at 15:01 -0500, Steven Rostedt wrote:
>
> What I was hinting at was that the spin_lock() can boost, but it could
> also fail if there was a deadlock detected, and it wouldn't cause the
> system to hang.
Right, that's spin_deadlock() ;-) And you can in fact write
spin_trydeadlock() as:
int spin_trydeadlock(spinlock_t *lock)
{
return spin_deadlock(lock) != -EDEADLK;
}
The advantage of introducing spin_trydeadlock() is that you can merge it
upstream (modulo naming) and the !RT code won't change at all.
IIRC tglx said there were more sites than just the dcache that did this
inverse lock order trylock game.
Seems we're agreeing more than disagreeing.. anyway, if you care to give
it a go.. worst that can happen is that you'll get as big a mess as tglx
got :-)
prev parent reply other threads:[~2012-03-08 20:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 21:49 [ANNOUNCE] 3.2.9-rt17 Thomas Gleixner
2012-03-08 18:23 ` Steven Rostedt
2012-03-08 18:28 ` Peter Zijlstra
2012-03-08 18:42 ` Steven Rostedt
2012-03-08 19:39 ` Peter Zijlstra
2012-03-08 20:10 ` Steven Rostedt
2012-03-08 20:26 ` Peter Zijlstra
2012-03-08 21:08 ` Steven Rostedt
2012-03-08 21:20 ` Peter Zijlstra
2012-03-08 21:25 ` Steven Rostedt
2012-03-08 21:28 ` Peter Zijlstra
2012-03-08 21:36 ` Steven Rostedt
2012-03-08 21:37 ` Peter Zijlstra
2012-03-08 21:44 ` Steven Rostedt
2012-03-08 21:54 ` Peter Zijlstra
2012-03-08 22:13 ` Steven Rostedt
2012-03-08 22:20 ` Peter Zijlstra
2012-03-08 22:27 ` Steven Rostedt
2012-03-09 4:17 ` Steven Rostedt
2012-03-09 0:33 ` Thomas Gleixner
2012-03-09 3:08 ` Steven Rostedt
2012-03-09 0:20 ` Thomas Gleixner
2012-03-09 2:50 ` Steven Rostedt
2012-03-09 10:23 ` Thomas Gleixner
2012-03-09 12:51 ` Steven Rostedt
2012-03-08 19:48 ` Peter Zijlstra
2012-03-08 20:01 ` Steven Rostedt
2012-03-08 20:08 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331237303.11248.413.camel@twins \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).