From: Steven Rostedt <rostedt@goodmis.org>
To: Christophe Huriaux <c.huriaux@gmail.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-rt-users@vger.kernel.org
Subject: Re: BUG - "scheduling while atomic" on a irq handler (s3c-mci)
Date: Tue, 15 May 2012 13:38:48 -0400 [thread overview]
Message-ID: <1337103528.14207.342.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <CAEOomG9FZD9TEQZZKhCrNrq8SNXi3otWB2mDX69i3tWh5YQenw@mail.gmail.com>
On Thu, 2012-05-10 at 15:17 +0200, Christophe Huriaux wrote:
>
> From: Christophe Huriaux <c.huriaux@gmail.com>
> Subject: [PATCH] Fix scheduling while atomic bug in pio_tasklet
> Signed-off-by: Christophe Huriaux <c.huriaux@gmail.com>
> ---
> drivers/mmc/host/s3cmci.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
> index 720f993..9978ad6 100644
> --- a/drivers/mmc/host/s3cmci.c
> +++ b/drivers/mmc/host/s3cmci.c
> @@ -329,7 +329,11 @@ static void s3cmci_enable_irq(struct s3cmci_host
> *host, bool more)
> if (enable)
> enable_irq(host->irq);
> else
> +#ifdef CONFIG_PREEMPT_RT_BASE
> + disable_irq_nosync(host->irq);
> +#else
> disable_irq(host->irq);
> +#endif
> }
>
> local_irq_restore(flags);
> @@ -350,7 +354,11 @@ static void s3cmci_disable_irq(struct s3cmci_host
> *host, bool transfer)
>
> if (transfer && host->irq_state) {
> host->irq_state = false;
> +#ifdef CONFIG_PREEMPT_RT_BASE
> + disable_irq_nosync(host->irq);
> +#else
> disable_irq(host->irq);
> +#endif
> }
>
> local_irq_restore(flags);
What happens if you instead convert the local_irq_save/restore() to
local_irq_save_nort/restore_nort()?
Does that work too?
-- Steve
next prev parent reply other threads:[~2012-05-15 17:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 14:07 BUG - "scheduling while atomic" on a irq handler (s3c-mci) Christophe Huriaux
2012-05-09 17:49 ` Uwe Kleine-König
2012-05-10 13:17 ` Christophe Huriaux
2012-05-15 17:38 ` Steven Rostedt [this message]
2012-05-20 5:27 ` [PATCH] genirq: don't sync irq thread if current happen to be the very irq thread Yong Zhang
2012-05-20 12:19 ` [PATCH v2] " Yong Zhang
2012-05-22 13:50 ` Thomas Gleixner
2012-05-23 6:54 ` Yong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337103528.14207.342.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=c.huriaux@gmail.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).