From: Steven Rostedt <rostedt@goodmis.org>
To: Clark Williams <williams@redhat.com>
Cc: Ben Hutchings <ben@decadent.org.uk>,
LKML <linux-kernel@vger.kernel.org>,
RT <linux-rt-users@vger.kernel.org>,
Arend van Spriel <arend@broadcom.com>,
Pieter-Paul Giesberts <pieterpg@broadcom.com>,
BrettRudley <brudley@broadcom.com>,
"John W. Linville" <linville@tuxdriver.com>,
Roland Vossen <rvossen@broadcom.com>
Subject: Re: [PATCH] compile fix for brcm80211 on v3.2.17
Date: Tue, 15 May 2012 15:22:14 -0400 [thread overview]
Message-ID: <1337109734.14207.348.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20120515140413.04c19fad@redhat.com>
On Tue, 2012-05-15 at 14:04 -0500, Clark Williams wrote:
> Ben,
>
> Found this while building v3.2.17-rt28:
>
> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c
> index f98becc..833cbef 100644
> --- a/drivers/net/wireless/brcm80211/brcmsmac/main.c
> +++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c
> @@ -7879,7 +7879,7 @@ brcms_c_recvctl(struct brcms_c_info *wlc, struct d11rxhdr *rxh,
> if (wlc->hw->suspended_fifos) {
> hdr = (struct ieee80211_hdr *)p->data;
> if (ieee80211_is_beacon(hdr->frame_control))
> - brcms_b_mute(wlc->hw, false);
> + brcms_b_mute(wlc->hw, false, 0);
> }
>
> memcpy(IEEE80211_SKB_RXCB(p), &rx_status, sizeof(rx_status));
>
> Not sure if that's completely correct but I found another call site for
> brcms_b_mute() that also passed 0 flags.
The bug was caused by this patch:
commit d609909f0d6c69937057237b3eff577311d08d07
Author: Arend van Spriel <arend@broadcom.com>
brcm80211: smac: resume transmit fifo upon receiving frames
(mainline: badc4f07622f0f7093a201638f45e85765f1b5e4)
Because it was added to mainline after this patch:
commit c6c44893c864429a7c6a4f7942dfb3ee182b4ad1
Author: Roland Vossen <rvossen@broadcom.com>
brcm80211: smac: fixed inconsistency in transmit mute
Which converted brcms_b_mute() from 3 arguments to 2.
-- Steve
next prev parent reply other threads:[~2012-05-15 19:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 19:04 [PATCH] compile fix for brcm80211 on v3.2.17 Clark Williams
2012-05-15 19:22 ` Steven Rostedt [this message]
2012-05-16 0:56 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337109734.14207.348.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=arend@broadcom.com \
--cc=ben@decadent.org.uk \
--cc=brudley@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=pieterpg@broadcom.com \
--cc=rvossen@broadcom.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).