From: Peter Zijlstra <peterz@infradead.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: pjt@google.com, paul.mckenney@linaro.org, tglx@linutronix.de,
tj@kernel.org, suresh.b.siddha@intel.com, venki@google.com,
mingo@redhat.com, rostedt@goodmis.org,
linaro-kernel@lists.linaro.org, robin.randhawa@arm.com,
Steve.Bannister@arm.com, Liviu.Dudau@arm.com,
charles.garcia-tobin@arm.com, Arvind.Chauhan@arm.com,
linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 1/7] sched: Create sched_select_cpu() to give preferred CPU for power saving
Date: Tue, 19 Mar 2013 13:30:32 +0100 [thread overview]
Message-ID: <1363696232.22553.37.camel@laptop> (raw)
In-Reply-To: <9f0fd16f792b9f9b399a4c91c98de37c56067d47.1363617402.git.viresh.kumar@linaro.org>
On Mon, 2013-03-18 at 20:53 +0530, Viresh Kumar wrote:
> +/*
> + * This routine returns the nearest non-idle cpu. It accepts a
> bitwise OR of
> + * SD_* flags present in linux/sched.h. If the local CPU isn't idle,
> it is
> + * returned back. If it is idle, then we must look for another CPU
> which have
> + * all the flags passed as argument as set.
> + */
> +int sched_select_cpu(unsigned int sd_flags)
So the only problem I have is that you expose the SD_flags to !sched
code. The only proposed user is in the workqueue code and passes 0.
Why not leave out the sd_flags argument and introduce it once you start
using it; at which point we can argue on the interface.
next prev parent reply other threads:[~2013-03-19 12:30 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 15:23 [PATCH V3 0/7] Create sched_select_cpu() and use it for workqueues Viresh Kumar
2013-03-18 15:23 ` [PATCH V3 1/7] sched: Create sched_select_cpu() to give preferred CPU for power saving Viresh Kumar
2013-03-18 15:39 ` Frederic Weisbecker
2013-03-18 15:44 ` Viresh Kumar
2013-03-18 15:57 ` Frederic Weisbecker
2013-03-19 5:15 ` Viresh Kumar
2013-03-19 12:30 ` Peter Zijlstra [this message]
2013-03-19 12:52 ` Viresh Kumar
2013-03-19 13:22 ` Viresh Kumar
2013-03-18 15:23 ` [PATCH V3 2/7] timer: hrtimer: Don't check idle_cpu() before calling get_nohz_timer_target() Viresh Kumar
2013-03-18 15:23 ` [PATCH V3 3/7] workqueue: Add helpers to schedule work on any cpu Viresh Kumar
2013-03-19 5:15 ` Viresh Kumar
2013-03-19 13:23 ` Viresh Kumar
2013-03-21 0:12 ` Tejun Heo
2013-03-21 10:57 ` Viresh Kumar
2013-03-21 18:29 ` Tejun Heo
2013-03-28 18:13 ` Tejun Heo
2013-03-29 2:39 ` Viresh Kumar
2013-03-29 7:27 ` Viresh Kumar
2013-03-29 17:40 ` Tejun Heo
2013-03-29 17:56 ` Tejun Heo
2013-03-30 3:30 ` Viresh Kumar
2013-03-18 15:23 ` [PATCH V3 4/7] PHYLIB: queue " Viresh Kumar
2013-03-18 17:33 ` David Miller
2013-03-18 15:23 ` [PATCH V3 5/7] mmc: " Viresh Kumar
2013-03-19 7:58 ` Ulf Hansson
2013-03-22 17:09 ` Chris Ball
2013-03-22 17:26 ` Chris Ball
2013-03-22 17:27 ` Viresh Kumar
2013-03-22 17:30 ` Chris Ball
2013-03-18 15:23 ` [PATCH V3 6/7] block: " Viresh Kumar
2013-03-22 15:05 ` Jens Axboe
2013-03-23 6:44 ` Viresh Kumar
2013-03-18 15:23 ` [PATCH V3 7/7] fbcon: " Viresh Kumar
2013-03-19 5:00 ` [PATCH V3 0/7] Create sched_select_cpu() and use it for workqueues Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363696232.22553.37.camel@laptop \
--to=peterz@infradead.org \
--cc=Arvind.Chauhan@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=charles.garcia-tobin@arm.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul.mckenney@linaro.org \
--cc=pjt@google.com \
--cc=robin.randhawa@arm.com \
--cc=rostedt@goodmis.org \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=venki@google.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).