linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: <linux-ext4@vger.kernel.org>, <linux-rt-users@vger.kernel.org>,
	Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH v2 0/6] misc jbd2 fixes and cleanups
Date: Tue, 11 Jun 2013 18:44:24 -0400	[thread overview]
Message-ID: <1370990670-49249-1-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1370892723-30860-1-git-send-email-paul.gortmaker@windriver.com>

This is a series of commits that came about while researching a problem
on a preempt-rt kernel.  The RT problem seems tied to the function
jbd2_journal_commit_transaction, hence the common theme/location in
this series.

That said, it turns out that there is nothing in these commits that is
specific to RT, so they were reviewed with the aim to mainline them
(and also continue to research the RT problem...)

Once these have been placed in a non-rebased branch with fixed commit
IDs, I'll submit ext3/jbd versions of the same where appropriate.

Testing has involved ensuring jbd_debug still works (with the newly
documented non-debugfs module param) and also with a largely parallel
yocto build running concurrently with a large "rm -rf" (i.e. the test
that has been problematic on 3.4.x/3.6.x preempt-rt kernels).

Thanks,
Paul.

---

Changes since v1:
  --assert after state lock is now a standalone/separate commit
  --add jbd2-only va_args patch for jbd_debug in manner suggested by Ted
  --fix log_wait_for_space patch to avoid extra mutex lock/unlock
  --add new patch to fix stale data/dependency in jbd2/Kconfig


The following changes since commit 317ddd256b9c24b0d78fa8018f80f1e495481a10:

  Linux 3.10-rc5 (2013-06-08 17:41:04 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux.git jbd2-fixes

for you to fetch changes up to 26a48f70423cc58f5fbaf1d8fcd703e8bd455aef:

  jbd2: remove debug dependency on debug_fs; update help text (2013-06-11 17:58:42 -0400)

----------------------------------------------------------------
Paul Gortmaker (6):
      jbd2/journal_commit_transaction: relocate assert after state lock
      jbd2/log_wait_for_space: drop checkpoint mutex when waiting
      jbd2: fix duplicate debug label for phase 2
      jbd/jbd2: relocate bit_spinlock header to jbd_common
      jbd2: make jbd_debug that won't split printk statements
      jbd2: remove debug dependency on debug_fs; update help text

 fs/jbd2/Kconfig            |  6 +++---
 fs/jbd2/checkpoint.c       |  8 ++++++++
 fs/jbd2/commit.c           |  6 +++---
 fs/jbd2/journal.c          | 17 +++++++++++++++++
 include/linux/jbd.h        |  1 -
 include/linux/jbd2.h       | 15 +++++----------
 include/linux/jbd_common.h |  2 ++
 7 files changed, 38 insertions(+), 17 deletions(-)

  parent reply	other threads:[~2013-06-11 22:44 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-10 19:31 [RFC PATCH 0/4] ext4/jbd2: several possible mainline fixes Paul Gortmaker
2013-06-10 19:32 ` [PATCH 1/4] jbd2/journal_commit_transaction: relocate state lock to incorporate all users Paul Gortmaker
2013-06-11  2:12   ` Theodore Ts'o
2013-06-11  2:45     ` Paul Gortmaker
2013-06-11  2:52       ` Theodore Ts'o
2013-06-11 17:38     ` Paul Gortmaker
2013-06-11 17:53       ` Theodore Ts'o
2013-06-11 18:48         ` Paul Gortmaker
2013-06-11 21:54           ` Paul Gortmaker
2013-06-10 19:32 ` [PATCH 2/4] jbd2/log_wait_for_space: drop checkpoint mutex when waiting Paul Gortmaker
2013-06-11  2:33   ` Theodore Ts'o
2013-06-11  3:20     ` Paul Gortmaker
2013-06-11 13:03       ` Theodore Ts'o
2013-06-11 13:20         ` Paul Gortmaker
2013-06-10 19:32 ` [PATCH 3/4] jbd2: fix duplicate debug label for phase 2 Paul Gortmaker
2013-06-10 19:32 ` [PATCH 4/4] jbd/jbd2: relocate bit_spinlock header to jbd_common Paul Gortmaker
2013-06-10 23:38 ` [RFC PATCH 0/4] ext4/jbd2: several possible mainline fixes Theodore Ts'o
2013-06-11  3:09   ` Paul Gortmaker
2013-06-11 22:44 ` Paul Gortmaker [this message]
2013-06-11 22:44   ` [PATCH 1/6] jbd2/journal_commit_transaction: relocate assert after state lock Paul Gortmaker
2013-06-13  2:42     ` Theodore Ts'o
2013-06-11 22:44   ` [PATCH 2/6] jbd2/log_wait_for_space: drop checkpoint mutex when waiting Paul Gortmaker
2013-06-13  2:55     ` Theodore Ts'o
2013-06-11 22:44   ` [PATCH 3/6] jbd2: fix duplicate debug label for phase 2 Paul Gortmaker
2013-06-13  2:57     ` Theodore Ts'o
2013-06-11 22:44   ` [PATCH 4/6] jbd/jbd2: relocate bit_spinlock header to jbd_common Paul Gortmaker
2013-06-13  3:02     ` Theodore Ts'o
2013-06-11 22:44   ` [PATCH 5/6] jbd2: make jbd_debug that won't split printk statements Paul Gortmaker
2013-06-11 22:44   ` [PATCH 6/6] jbd2: remove debug dependency on debug_fs; update help text Paul Gortmaker
2013-06-13  3:08     ` Theodore Ts'o
2013-06-13 13:51       ` Paul Gortmaker
2013-06-13 14:14         ` Theodore Ts'o
2013-06-13 14:47           ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370990670-49249-1-git-send-email-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).