linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: minyard@acm.org
To: linux-rt-users@vger.kernel.org
Cc: Corey Minyard <cminyard@cavium.com>
Subject: [PATCH] slab+rt: Don't free locks twice in cpuup_canceled
Date: Fri, 20 Sep 2013 13:02:29 -0500	[thread overview]
Message-ID: <1379700149-16400-1-git-send-email-minyard@acm.org> (raw)

From: Corey Minyard <cminyard@mvista.com>

Signed-off-by: Corey Minyard <cminyard@cavium.com>
---
 mm/slab.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/mm/slab.c b/mm/slab.c
index 494274e..0a3d6d3 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -1270,7 +1270,6 @@ static void __cpuinit cpuup_canceled(long cpu)
 			free_block(cachep, nc->entry, nc->avail, node);
 
 		if (!cpumask_empty(mask)) {
-			local_spin_unlock_irq(slab_lock, &n->list_lock);
 			unlock_l3_and_free_delayed(&n->list_lock);
 			goto free_array_cache;
 		}
@@ -1285,7 +1284,6 @@ static void __cpuinit cpuup_canceled(long cpu)
 		alien = n->alien;
 		n->alien = NULL;
 
-		local_spin_unlock_irq(slab_lock, &n->list_lock);
 		unlock_l3_and_free_delayed(&n->list_lock);
 
 		kfree(shared);
-- 
1.8.3.1


             reply	other threads:[~2013-09-20 19:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-20 18:02 minyard [this message]
2013-09-25 16:37 ` [PATCH] slab+rt: Don't free locks twice in cpuup_canceled Corey Minyard
2013-10-04 14:49   ` Sebastian Andrzej Siewior
2013-10-04 16:10     ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379700149-16400-1-git-send-email-minyard@acm.org \
    --to=minyard@acm.org \
    --cc=cminyard@cavium.com \
    --cc=linux-rt-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).