From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: <linux-rt-users@vger.kernel.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH v3.10-rt] slab: make kmem_cache_node's list_lock conditionally raw
Date: Tue, 8 Oct 2013 14:55:09 -0400 [thread overview]
Message-ID: <1381258509-7420-1-git-send-email-paul.gortmaker@windriver.com> (raw)
The RT patch "mm-disable-slab-on-rt.patch" unconditionally
converts kmem_cache_node's list_lock into a raw lock. As
of mainline commit ca34956b804b7554fc4e88826773380d9d5122a8
("slab: Common definition for kmem_cache_node") the definition
is shared -- but slab.c still thinks the lock is non raw.
At the moment SLAB depends on !RT_FULL, however with the lock
being raw for !RT_FULL, we can't build the SLAB + !RT_FULL
combination because of the above. So only convert the lock if
SLAB is not enabled.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
[Should be squished into mm-disable-slab-on-rt.patch ]
mm/slab.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/mm/slab.h b/mm/slab.h
index 2e6c8b7..fc3c097 100644
--- a/mm/slab.h
+++ b/mm/slab.h
@@ -247,7 +247,11 @@ static inline struct kmem_cache *cache_from_obj(struct kmem_cache *s, void *x)
* The slab lists for all objects.
*/
struct kmem_cache_node {
+#ifdef CONFIG_SLAB
+ spinlock_t list_lock;
+#else
raw_spinlock_t list_lock;
+#endif
#ifdef CONFIG_SLAB
struct list_head slabs_partial; /* partial list first, better asm code */
--
1.8.1.2
next reply other threads:[~2013-10-08 18:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 18:55 Paul Gortmaker [this message]
2013-10-11 13:16 ` [PATCH v3.10-rt] slab: make kmem_cache_node's list_lock conditionally raw Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381258509-7420-1-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=bigeasy@linutronix.de \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).