linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [ANNOUNCE] 3.12.22-rt33
@ 2014-06-19  0:12 Steven Rostedt
  2014-06-19  3:46 ` Mike Galbraith
  0 siblings, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2014-06-19  0:12 UTC (permalink / raw)
  To: LKML, linux-rt-users
  Cc: Thomas Gleixner, Carsten Emde, John Kacur,
	Sebastian Andrzej Siewior


Dear RT Folks,

I'm pleased to announce the 3.12.22-rt33 stable release.


This release is just an update to the new stable 3.12.22 version
and no RT specific changes have been made.


You can get this release via the git tree at:

  git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git

  branch: v3.12-rt
  Head SHA1: 4baf645b5bfe1bc83f21e6b0cdcacb411a1e5f15


Or to build 3.12.22-rt33 directly, the following patches should be applied:

  http://www.kernel.org/pub/linux/kernel/v3.x/linux-3.12.tar.xz

  http://www.kernel.org/pub/linux/kernel/v3.x/patch-3.12.22.xz

  http://www.kernel.org/pub/linux/kernel/projects/rt/3.12/patch-3.12.22-rt33.patch.xz




Enjoy,

-- Steve

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ANNOUNCE] 3.12.22-rt33
  2014-06-19  0:12 [ANNOUNCE] 3.12.22-rt33 Steven Rostedt
@ 2014-06-19  3:46 ` Mike Galbraith
  2014-06-19 13:44   ` Steven Rostedt
  0 siblings, 1 reply; 4+ messages in thread
From: Mike Galbraith @ 2014-06-19  3:46 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: LKML, linux-rt-users, Thomas Gleixner, Carsten Emde, John Kacur,
	Sebastian Andrzej Siewior

On Wed, 2014-06-18 at 20:12 -0400, Steven Rostedt wrote: 
> Dear RT Folks,
> 
> I'm pleased to announce the 3.12.22-rt33 stable release.


git@marge:~/linux-2.6> git diff v3.12... drivers/net/ethernet/dec/tulip/tulip_core.c
diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
index 4e8cfa2ac803..a6d4653ebbc3 100644
--- a/drivers/net/ethernet/dec/tulip/tulip_core.c
+++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
@@ -1939,7 +1939,9 @@ static void tulip_remove_one(struct pci_dev *pdev)
 	pci_iounmap(pdev, tp->base_addr);
 	free_netdev (dev);
 	pci_release_regions (pdev);
+	pci_disable_device(pdev);
 	pci_set_drvdata (pdev, NULL);
+	pci_disable_device(pdev);
 
 	/* pci_power_off (pdev, -1); */
 }

commit 4a77edc195f0b03644e84dda00fcfe9827868e8e
Author: Ingo Molnar <mingo@elte.hu>
Date:   Fri Jul 3 08:30:18 2009 -0500

    drivers/net: tulip_remove_one needs to call pci_disable_device()
    
    Otherwise the device is not completely shut down.
    
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
index 4e8cfa2ac803..7565b994ec50 100644
--- a/drivers/net/ethernet/dec/tulip/tulip_core.c
+++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
@@ -1939,6 +1939,7 @@ static void tulip_remove_one(struct pci_dev *pdev)
 	pci_iounmap(pdev, tp->base_addr);
 	free_netdev (dev);
 	pci_release_regions (pdev);
+	pci_disable_device(pdev);
 	pci_set_drvdata (pdev, NULL);
 
 	/* pci_power_off (pdev, -1); */


commit 831bb5573dcbeb0da783c82e21084ac191dafc24
Author: Ingo Molnar <mingo@elte.hu>
Date:   Fri Feb 14 15:32:20 2014 +0100

    drivers/net: tulip_remove_one needs to call pci_disable_device()
    
    commit c321f7d7c87cdc623c87845f6378620573e57512 upstream.
    
    Otherwise the device is not completely shut down.
    
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>

diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
index 4e8cfa2ac803..779016068a82 100644
--- a/drivers/net/ethernet/dec/tulip/tulip_core.c
+++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
@@ -1940,6 +1940,7 @@ static void tulip_remove_one(struct pci_dev *pdev)
 	free_netdev (dev);
 	pci_release_regions (pdev);
 	pci_set_drvdata (pdev, NULL);
+	pci_disable_device(pdev);
 
 	/* pci_power_off (pdev, -1); */
 }

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [ANNOUNCE] 3.12.22-rt33
  2014-06-19  3:46 ` Mike Galbraith
@ 2014-06-19 13:44   ` Steven Rostedt
  2014-06-20  8:03     ` Mike Galbraith
  0 siblings, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2014-06-19 13:44 UTC (permalink / raw)
  To: Mike Galbraith
  Cc: LKML, linux-rt-users, Thomas Gleixner, Carsten Emde, John Kacur,
	Sebastian Andrzej Siewior

On Thu, 19 Jun 2014 05:46:43 +0200
Mike Galbraith <umgwanakikbuti@gmail.com> wrote:

> On Wed, 2014-06-18 at 20:12 -0400, Steven Rostedt wrote: 
> > Dear RT Folks,
> > 
> > I'm pleased to announce the 3.12.22-rt33 stable release.

Didn't we have this issue before?

> 
> 
> git@marge:~/linux-2.6> git diff v3.12... drivers/net/ethernet/dec/tulip/tulip_core.c
> diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
> index 4e8cfa2ac803..a6d4653ebbc3 100644
> --- a/drivers/net/ethernet/dec/tulip/tulip_core.c
> +++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
> @@ -1939,7 +1939,9 @@ static void tulip_remove_one(struct pci_dev *pdev)
>  	pci_iounmap(pdev, tp->base_addr);
>  	free_netdev (dev);
>  	pci_release_regions (pdev);
> +	pci_disable_device(pdev);
>  	pci_set_drvdata (pdev, NULL);
> +	pci_disable_device(pdev);
>  
>  	/* pci_power_off (pdev, -1); */
>  }
> 
> commit 4a77edc195f0b03644e84dda00fcfe9827868e8e
> Author: Ingo Molnar <mingo@elte.hu>
> Date:   Fri Jul 3 08:30:18 2009 -0500
> 
>     drivers/net: tulip_remove_one needs to call pci_disable_device()
>     
>     Otherwise the device is not completely shut down.

Grumble, this was a fix that went into -rt without going into stable
first.

OK, I'll remove this commit and keep the stable one.

Thanks!

-- Steve

>     
>     Signed-off-by: Ingo Molnar <mingo@elte.hu>
>     Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> 
> diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
> index 4e8cfa2ac803..7565b994ec50 100644
> --- a/drivers/net/ethernet/dec/tulip/tulip_core.c
> +++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
> @@ -1939,6 +1939,7 @@ static void tulip_remove_one(struct pci_dev *pdev)
>  	pci_iounmap(pdev, tp->base_addr);
>  	free_netdev (dev);
>  	pci_release_regions (pdev);
> +	pci_disable_device(pdev);
>  	pci_set_drvdata (pdev, NULL);
>  
>  	/* pci_power_off (pdev, -1); */
> 
> 
> commit 831bb5573dcbeb0da783c82e21084ac191dafc24
> Author: Ingo Molnar <mingo@elte.hu>
> Date:   Fri Feb 14 15:32:20 2014 +0100
> 
>     drivers/net: tulip_remove_one needs to call pci_disable_device()
>     
>     commit c321f7d7c87cdc623c87845f6378620573e57512 upstream.
>     
>     Otherwise the device is not completely shut down.
>     
>     Signed-off-by: Ingo Molnar <mingo@elte.hu>
>     Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>     Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>     Signed-off-by: David S. Miller <davem@davemloft.net>
>     Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> 
> diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
> index 4e8cfa2ac803..779016068a82 100644
> --- a/drivers/net/ethernet/dec/tulip/tulip_core.c
> +++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
> @@ -1940,6 +1940,7 @@ static void tulip_remove_one(struct pci_dev *pdev)
>  	free_netdev (dev);
>  	pci_release_regions (pdev);
>  	pci_set_drvdata (pdev, NULL);
> +	pci_disable_device(pdev);

>  
>  	/* pci_power_off (pdev, -1); */
>  }
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ANNOUNCE] 3.12.22-rt33
  2014-06-19 13:44   ` Steven Rostedt
@ 2014-06-20  8:03     ` Mike Galbraith
  0 siblings, 0 replies; 4+ messages in thread
From: Mike Galbraith @ 2014-06-20  8:03 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: LKML, linux-rt-users, Thomas Gleixner, Carsten Emde, John Kacur,
	Sebastian Andrzej Siewior

On Thu, 2014-06-19 at 09:44 -0400, Steven Rostedt wrote: 
> On Thu, 19 Jun 2014 05:46:43 +0200
> Mike Galbraith <umgwanakikbuti@gmail.com> wrote:
> 
> > On Wed, 2014-06-18 at 20:12 -0400, Steven Rostedt wrote: 
> > > Dear RT Folks,
> > > 
> > > I'm pleased to announce the 3.12.22-rt33 stable release.
> 
> Didn't we have this issue before?

Yup, and correcting it didn't go all that well for either of us ;-)
It's all better now.

-Mike

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-06-20  8:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-19  0:12 [ANNOUNCE] 3.12.22-rt33 Steven Rostedt
2014-06-19  3:46 ` Mike Galbraith
2014-06-19 13:44   ` Steven Rostedt
2014-06-20  8:03     ` Mike Galbraith

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).