[PATCH] Makefile: allow building selected tests with non-NPTL toolchain

[PATCH] Makefile: allow building selected tests with non-NPTL toolchain

[Alexey Brodkin]

Some architectures are still stuck with non-NPTL toolchains.
These are for example ARC, Blackfin, Xtensa etc.

Still rt-tests are very good benchmarks and it would be good to enable use of
at least selected (those that will be built) tests on those architectures.

This change makes it possible to only build subset of tests that don't require
NPTL calls.

By default behavior is not modified - all tests are built, but if one wants
to build with non-NPTL toolchain just add "HAVE_NPTL=no" in command line
or modify "HAVE_NPTL" variable right in Makefile and execute "make".

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Vineet Gupta <vgupta@synopsys.com>
Cc: Clark Williams <clark.williams@gmail.com>
---
 Makefile | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index 318a5c6..675edf7 100644
--- a/Makefile
+++ b/Makefile
@@ -1,8 +1,13 @@
 VERSION_STRING = 0.89
 
-sources = cyclictest.c signaltest.c pi_stress.c rt-migrate-test.c	\
-	  ptsematest.c sigwaittest.c svsematest.c pmqtest.c sendme.c 	\
-	  pip_stress.c hackbench.c
+HAVE_NPTL ?= yes
+
+ifeq ($(HAVE_NPTL),yes)
+sources = cyclictest.c pi_stress.c pip_stress.c pmqtest.c rt-migrate-test.c
+endif
+
+sources += signaltest.c ptsematest.c sigwaittest.c svsematest.c sendme.c \
+	  hackbench.c
 
 TARGETS = $(sources:.c=)
 
-- 
1.9.3

Re: [PATCH] Makefile: allow building selected tests with non-NPTL toolchain

[Alexey Brodkin]

Hi Clark, John,

On Mon, 2014-11-10 at 10:16 +0300, Alexey Brodkin wrote:
> Some architectures are still stuck with non-NPTL toolchains.
> These are for example ARC, Blackfin, Xtensa etc.
> 
> Still rt-tests are very good benchmarks and it would be good to enable use of
> at least selected (those that will be built) tests on those architectures.
> 
> This change makes it possible to only build subset of tests that don't require
> NPTL calls.
> 
> By default behavior is not modified - all tests are built, but if one wants
> to build with non-NPTL toolchain just add "HAVE_NPTL=no" in command line
> or modify "HAVE_NPTL" variable right in Makefile and execute "make".
> 
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Vineet Gupta <vgupta@synopsys.com>
> Cc: Clark Williams <clark.williams@gmail.com>
> ---
>  Makefile | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 318a5c6..675edf7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1,8 +1,13 @@
>  VERSION_STRING = 0.89
>  
> -sources = cyclictest.c signaltest.c pi_stress.c rt-migrate-test.c	\
> -	  ptsematest.c sigwaittest.c svsematest.c pmqtest.c sendme.c 	\
> -	  pip_stress.c hackbench.c
> +HAVE_NPTL ?= yes
> +
> +ifeq ($(HAVE_NPTL),yes)
> +sources = cyclictest.c pi_stress.c pip_stress.c pmqtest.c rt-migrate-test.c
> +endif
> +
> +sources += signaltest.c ptsematest.c sigwaittest.c svsematest.c sendme.c \
> +	  hackbench.c
>  
>  TARGETS = $(sources:.c=)

I'm wondering if there's a chance to get this patch reviewed and if
there're no objections applied?

Regards,
Alexey

Re: [PATCH] Makefile: allow building selected tests with non-NPTL toolchain

[Clark Williams]

[-- Attachment #1: Type: text/plain, Size: 1950 bytes --]

On Thu, 15 Jan 2015 07:35:01 +0000
Alexey Brodkin <Alexey.Brodkin@synopsys.com> wrote:

> Hi Clark, John,
> 
> On Mon, 2014-11-10 at 10:16 +0300, Alexey Brodkin wrote:
> > Some architectures are still stuck with non-NPTL toolchains.
> > These are for example ARC, Blackfin, Xtensa etc.
> > 
> > Still rt-tests are very good benchmarks and it would be good to enable use of
> > at least selected (those that will be built) tests on those architectures.
> > 
> > This change makes it possible to only build subset of tests that don't require
> > NPTL calls.
> > 
> > By default behavior is not modified - all tests are built, but if one wants
> > to build with non-NPTL toolchain just add "HAVE_NPTL=no" in command line
> > or modify "HAVE_NPTL" variable right in Makefile and execute "make".
> > 
> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > Cc: Vineet Gupta <vgupta@synopsys.com>
> > Cc: Clark Williams <clark.williams@gmail.com>
> > ---
> >  Makefile | 11 ++++++++---
> >  1 file changed, 8 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Makefile b/Makefile
> > index 318a5c6..675edf7 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1,8 +1,13 @@
> >  VERSION_STRING = 0.89
> >  
> > -sources = cyclictest.c signaltest.c pi_stress.c rt-migrate-test.c	\
> > -	  ptsematest.c sigwaittest.c svsematest.c pmqtest.c sendme.c 	\
> > -	  pip_stress.c hackbench.c
> > +HAVE_NPTL ?= yes
> > +
> > +ifeq ($(HAVE_NPTL),yes)
> > +sources = cyclictest.c pi_stress.c pip_stress.c pmqtest.c rt-migrate-test.c
> > +endif
> > +
> > +sources += signaltest.c ptsematest.c sigwaittest.c svsematest.c sendme.c \
> > +	  hackbench.c
> >  
> >  TARGETS = $(sources:.c=)
> 
> I'm wondering if there's a chance to get this patch reviewed and if
> there're no objections applied?
> 
> Regards,
> Alexey

Changes looked good to me. I've pulled it in and it will be in the next
release.

Clark

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]