linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Thavatchai Makphaibulchoke <thavatchai.makpahibulchoke@hp.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org,
	linux-rt-users <linux-rt-users@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Carsten Emde <C.Emde@osadl.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	John Kacur <jkacur@redhat.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [PATCH RT 2/4] Revert "timers: do not raise softirq unconditionally"
Date: Mon, 23 Mar 2015 05:42:54 +0100	[thread overview]
Message-ID: <1427085774.3151.7.camel@gmail.com> (raw)
In-Reply-To: <1426960943.4677.34.camel@gmail.com>

On Sat, 2015-03-21 at 19:02 +0100, Mike Galbraith wrote:
> On Thu, 2015-03-19 at 10:42 -0600, Thavatchai Makphaibulchoke wrote:
> > On 03/19/2015 10:26 AM, Steven Rostedt wrote:
> > > On Thu, 19 Mar 2015 09:17:09 +0100
> > > Mike Galbraith <umgwanakikbuti@gmail.com> wrote:
> > > 
> > > 
> > >> (aw crap, let's go shopping)... so why is the one in timer.c ok?
> > > 
> > > It's not. Sebastian, you said there were no other cases of rt_mutexes
> > > being taken in hard irq context. Looks like timer.c has one.
> > > 
> > > So perhaps the real fix is to get that special case of ownership in
> > > hard interrupt context?
> > > 
> > > -- Steve
> > > 
> > 
> > Steve, I'm still working on the fix we discussed using dummy irq_task.
> > I should be able to submit some time next week, if still interested.
> > 
> > Either that, or I think we should remove the function
> > spin_do_trylock_in_interrupt() to prevent any possibility of running
> > into similar problems in the future.
> 
> Why can't we just Let swapper be the owner when in irq with no dummy?
> 
> I have "don't raise timer unconditionally" re-applied, the check for a
> running callback bits of my nohz_full fixlet, and the below on top of
> that, and all _seems_ well.

But not so well on 64 core box.  That has nothing to do with hacklet
though, re-applying timers-do-not-raise-softirq-unconditionally.patch
without thta hangs the 64 core box during boot with no help from me
other than to patchlet to let nohz work at all, seems there's another
issue lurking there.  Hohum.  Without 'don't raise..", big box is fine.

	-Mike

  reply	other threads:[~2015-03-23  4:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-17 16:35 [PATCH RT 0/4] Linux 3.10.70-rt75-rc2 Steven Rostedt
2015-03-17 16:35 ` [PATCH RT 1/4] fs,btrfs: fix rt deadlock on extent_buffer->lock Steven Rostedt
2015-03-17 16:35 ` [PATCH RT 2/4] Revert "timers: do not raise softirq unconditionally" Steven Rostedt
2015-03-17 20:35   ` Steven Rostedt
2015-03-19  8:17     ` Mike Galbraith
2015-03-19 16:26       ` Steven Rostedt
2015-03-19 16:42         ` Thavatchai Makphaibulchoke
2015-03-21 18:02           ` Mike Galbraith
2015-03-23  4:42             ` Mike Galbraith [this message]
2015-03-26  2:17               ` Thavatchai Makphaibulchoke
2015-03-26  5:23                 ` Mike Galbraith
2015-03-26  6:01                   ` Mike Galbraith
2015-03-26  6:27                   ` Mike Galbraith
2015-03-26 13:53                     ` Steven Rostedt
2015-03-24 18:15             ` Sebastian Andrzej Siewior
2015-03-25  2:38               ` Mike Galbraith
2015-03-24 18:10         ` Sebastian Andrzej Siewior
2015-03-25  2:33           ` Mike Galbraith
2015-04-09 13:39             ` Sebastian Andrzej Siewior
2015-08-11 23:21               ` Jiang, Yunhong
2015-03-17 16:35 ` [PATCH RT 3/4] netpoll: guard the access to dev->npinfo with rcu_read_lock/unlock_bh() for CONFIG_PREEMPT_RT_FULL=y Steven Rostedt
2015-03-17 16:35 ` [PATCH RT 4/4] Linux 3.10.70-rt75-rc2 Steven Rostedt
  -- strict thread matches above, loose matches on Subject: below --
2015-03-17 16:30 [PATCH RT 0/4] Linux 3.12.38-rt53-rc2 Steven Rostedt
2015-03-17 16:30 ` [PATCH RT 2/4] Revert "timers: do not raise softirq unconditionally" Steven Rostedt
2015-03-17 16:25 [PATCH RT 0/4] Linux 3.14.34-rt32-rc2 Steven Rostedt
2015-03-17 16:25 ` [PATCH RT 2/4] Revert "timers: do not raise softirq unconditionally" Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427085774.3151.7.camel@gmail.com \
    --to=umgwanakikbuti@gmail.com \
    --cc=C.Emde@osadl.org \
    --cc=bigeasy@linutronix.de \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=thavatchai.makpahibulchoke@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).