linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: RT <linux-rt-users@vger.kernel.org>
Cc: John Kacur <jkacur@gmail.com>,
	"Gary S. Robertson" <gary.robertson@linaro.org>,
	Henning Schild <henning.schild@siemens.com>
Subject: [PATCH] cyclictest: remove compatibilty hack for old libnuma, repairs "-a" for isolcpus
Date: Wed, 20 May 2015 14:58:31 +0200	[thread overview]
Message-ID: <1432126711-18618-1-git-send-email-henning.schild@siemens.com> (raw)
In-Reply-To: <20150427125846.1de46037@sluggy>

Recent versions of libnuma >=2.0.9 all have numa_parse_cpustring_all(). Not
using this function will make the parser fail if isolcpus are used.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 src/cyclictest/rt_numa.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/src/cyclictest/rt_numa.h b/src/cyclictest/rt_numa.h
index 06c9420..64516f5 100644
--- a/src/cyclictest/rt_numa.h
+++ b/src/cyclictest/rt_numa.h
@@ -92,17 +92,7 @@ static inline unsigned int rt_numa_bitmask_isbitset( const struct bitmask *mask,
 static inline struct bitmask* rt_numa_parse_cpustring(const char* s,
 	int max_cpus)
 {
-#ifdef HAVE_PARSE_CPUSTRING_ALL		/* Currently not defined anywhere.  No
-					   autotools build. */
 	return numa_parse_cpustring_all(s);
-#else
-	/* We really need numa_parse_cpustring_all(), so we can assign threads
-	 * to cores which are part of an isolcpus set, but early 2.x versions of
-	 * libnuma do not have this function.  A work around should be to run
-	 * your command with e.g. taskset -c 9-15 <command>
-	 */
-	return numa_parse_cpustring((char *)s);
-#endif
 }
 
 static inline void rt_bitmask_free(struct bitmask *mask)
-- 
2.3.6


  reply	other threads:[~2015-05-20 12:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150427173222.04e8a1b1@md1em3qc>
2015-04-27 17:58 ` rt-tests, cyclictest libnuma and isolcpus Clark Williams
2015-05-20 12:58   ` Henning Schild [this message]
2015-05-20 14:38     ` [PATCH] cyclictest: remove compatibilty hack for old libnuma, repairs "-a" for isolcpus John Kacur
2015-05-20 19:54       ` Thomas Gleixner
     [not found]         ` <CAONaPpGpzzgjxQh+214cfOBVrqeX_yX=Kh981YyveHhTgyLA4A@mail.gmail.com>
2015-05-21 11:23           ` John Kacur
2015-05-21 11:11       ` Henning Schild
2015-05-21 12:23         ` Staffan Tjernstrom
2015-05-21 14:19           ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432126711-18618-1-git-send-email-henning.schild@siemens.com \
    --to=henning.schild@siemens.com \
    --cc=gary.robertson@linaro.org \
    --cc=jkacur@gmail.com \
    --cc=linux-rt-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).