From: Henrik Austad <haustad@cisco.com>
To: linux-rt-users@vger.kernel.org
Cc: Henrik Austad <henrik@austad.us>, John Kacur <jkacur@redhat.com>,
Henrik Austad <haustad@cisco.com>
Subject: [PATCH 3/4] android: Expand match for android in ostype
Date: Wed, 21 Oct 2015 15:49:01 +0200 [thread overview]
Message-ID: <1445435342-16969-4-git-send-email-haustad@cisco.com> (raw)
In-Reply-To: <1445435342-16969-1-git-send-email-haustad@cisco.com>
From: Henrik Austad <henrik@austad.us>
Some buildsystems use androidabe, so an exact match will break in those
circumstances.
Cc: John Kacur <jkacur@redhat.com>
Signed-off-by: Henrik Austad <haustad@cisco.com>
---
src/arch/android/Makefile | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/src/arch/android/Makefile b/src/arch/android/Makefile
index 8e169f080adb..4249311577f4 100644
--- a/src/arch/android/Makefile
+++ b/src/arch/android/Makefile
@@ -1,10 +1,14 @@
-# Bionic (android) does not have:
+# Android use Bionic for libc, and this does not have
# - pthread barriers
# - pthread_[gs]etaffinity
#
-# Typically see something like "aarch64-linux-android"
-ifeq (android,$(ostype))
+# This is all handled by bionic.h based on flags we set here.
+
+# Typically see something like "aarch64-linux-android". However, in some
+# buildsystems, it will be a variation of -androidabe.
+ost=$(findstring android, $(ostype))
+ifeq (android,$(ost))
USE_BIONIC := 1
CFLAGS += -DNO_PTHREAD_BARRIER
CFLAGS += -DNO_PTHREAD_SETAFFINITY
@@ -14,9 +18,7 @@ ifeq (android,$(ostype))
LIBS := $(filter-out -lrt,$(LIBS))
LIBS := $(filter-out -lpthread,$(LIBS))
-# BIONIC does not support PI, barriers and has different files in
-# include/. This means that currently, only these binaries will compile
-# and link properly:
+# Currently, only these binaries will compile and link properly for android
# - cyclictest
# - hackbench
sources := cyclictest.c hackbench.c
--
1.9.1
next prev parent reply other threads:[~2015-10-21 13:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 13:48 [PATCH 0/4] Android/Bionic cleanup patches Henrik Austad
2015-10-21 13:48 ` [PATCH 1/4] Android: clean up the bypass ifdeffery Henrik Austad
2015-10-21 16:39 ` John Kacur
2015-10-21 13:49 ` [PATCH 2/4] android: rename arch from bionic to android Henrik Austad
2015-10-21 13:49 ` Henrik Austad [this message]
2015-10-21 13:49 ` [PATCH 4/4] rt-sched.h: do not unconditionally define syscall-numbers Henrik Austad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445435342-16969-4-git-send-email-haustad@cisco.com \
--to=haustad@cisco.com \
--cc=henrik@austad.us \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).