From: Josh Cartwright <joshc@ni.com>
To: tglx@linutronix.de, bigeasy@linutronix.de
Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Eric Dumazet <eric.dumazet@gmail.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
"David S. Miller" <davem@davemloft.net>
Subject: [PATCH -rt] Revert "net: use synchronize_rcu_expedited()"
Date: Mon, 26 Oct 2015 14:14:55 -0500 [thread overview]
Message-ID: <1445886895-3692-1-git-send-email-joshc@ni.com> (raw)
This reverts commit be3fc413da9eb17cce0991f214ab019d16c88c41.
While the use of synchronize_rcu_expedited() might make
synchronize_net() "faster", it does so at significant cost on RT
systems, as expediting a grace period forcibly preempts any
high-priority RT tasks (via the stop_machine() mechanism).
Without be3fc413da9e reverted, we can observe a latency spike up to 30us
with cyclictest by rapidly unplugging/reestablishing an ethernet link.
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Josh Cartwright <joshc@ni.com>
---
net/core/dev.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index f8c23de..869ef62 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -6969,10 +6969,7 @@ EXPORT_SYMBOL(free_netdev);
void synchronize_net(void)
{
might_sleep();
- if (rtnl_is_locked())
- synchronize_rcu_expedited();
- else
- synchronize_rcu();
+ synchronize_rcu();
}
EXPORT_SYMBOL(synchronize_net);
--
2.5.1
next reply other threads:[~2015-10-26 19:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 19:14 Josh Cartwright [this message]
2015-10-27 0:44 ` [PATCH -rt] Revert "net: use synchronize_rcu_expedited()" Paul E. McKenney
2015-10-27 12:31 ` Josh Cartwright
2015-10-27 14:18 ` Eric Dumazet
2015-10-27 15:02 ` Arnaldo Carvalho de Melo
2015-10-27 15:27 ` Eric Dumazet
2015-10-27 23:15 ` Paul E. McKenney
2015-10-28 8:34 ` Josh Cartwright
2015-10-28 12:27 ` Paul E. McKenney
2015-10-30 9:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445886895-3692-1-git-send-email-joshc@ni.com \
--to=joshc@ni.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).