From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Clark Williams <williams@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [ANNOUNCE] 4.4-rc6-rt1
Date: Sat, 16 Jan 2016 14:23:22 +0100 [thread overview]
Message-ID: <1452950602.13755.9.camel@gmail.com> (raw)
In-Reply-To: <1452787507.15549.16.camel@gmail.com>
On Thu, 2016-01-14 at 17:05 +0100, Mike Galbraith wrote:
> This is virgin -rt1 modulo fixlet applied to v4.4.0, built with the
> .config from v4.4.0 that built it (modulo RT_FULL) rebuilding itself
> via make -j8.
>
> homer:/root # vmstat 10
> procs -----------memory---------- ---swap-- -----io---- -system-- ------cpu-----
> r b swpd free buff cache si so bi bo in cs us sy id wa st
> 0 1 0 14742988 179832 680792 0 0 634 25 326 1196 2 1 89 8 0
> 8 0 0 14476084 179848 701632 0 0 814 525 2421 12314 11 1 87 1 0
> 8 0 0 14483232 179864 712656 0 0 165 1628 2404 12320 11 1 87 1 0
> 8 0 0 14493336 180008 727836 0 0 141 762 2328 11306 11 1 87 0 0
> 8 0 0 14456436 180024 738356 0 0 159 1478 2336 11939 11 1 87 0 0
>
> Way too idle, taking forever.
It now being the weekend...
sched: Disable default set_cpus_allowed() method during update_migrate_disable().
update_migrate_disable() calls class::set_cpus_allowed(), when that method
is set_cpus_allowed_common(), writing to ->cpus_allowed defeats the intent
of migrate_disable(), permanently disabling migration instead.
Signed-off-by: Mike Galbraith <umgwanakikbuti@gmail.com>
---
kernel/sched/core.c | 2 ++
1 file changed, 2 insertions(+)
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1205,6 +1205,8 @@ static int migration_cpu_stop(void *data
*/
void set_cpus_allowed_common(struct task_struct *p, const struct cpumask *new_mask)
{
+ if (__migrate_disabled(p))
+ return;
cpumask_copy(&p->cpus_allowed, new_mask);
p->nr_cpus_allowed = cpumask_weight(new_mask);
}
next prev parent reply other threads:[~2016-01-16 13:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 22:57 [ANNOUNCE] 4.4-rc6-rt1 Sebastian Andrzej Siewior
2015-12-31 16:24 ` Clark Williams
2016-01-01 7:19 ` Mike Galbraith
2016-01-01 9:14 ` Thomas Gleixner
2016-01-01 9:45 ` Mike Galbraith
[not found] ` <568CF08F.3070001@caviumnetworks.com>
2016-01-13 11:45 ` [ANNOUNCE] 4.4-rc6-rt1 (arm64) Jaggi, Manish
2016-01-13 13:45 ` Sebastian Andrzej Siewior
2016-01-14 11:50 ` Jaggi, Manish
2016-01-13 17:58 ` [ANNOUNCE] 4.4-rc6-rt1 Sebastian Andrzej Siewior
2016-01-13 18:36 ` Grygorii Strashko
2016-01-14 14:59 ` Sebastian Andrzej Siewior
2016-01-14 9:33 ` Mike Galbraith
2016-01-14 14:17 ` Sebastian Andrzej Siewior
2016-01-14 14:29 ` Mike Galbraith
2016-01-14 14:30 ` Thomas Gleixner
2016-01-14 14:57 ` Mike Galbraith
2016-01-14 15:07 ` Thomas Gleixner
2016-01-14 16:05 ` Mike Galbraith
2016-01-16 13:23 ` Mike Galbraith [this message]
2016-01-16 13:43 ` Thomas Gleixner
2016-01-16 13:52 ` Mike Galbraith
2016-01-16 13:59 ` Thomas Gleixner
2016-01-16 14:09 ` Mike Galbraith
2016-01-07 12:15 ` Tim Sander
2016-01-13 13:40 ` Sebastian Andrzej Siewior
2016-01-22 15:35 ` Grygorii Strashko
2016-01-22 15:48 ` Sebastian Andrzej Siewior
2016-01-22 20:44 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452950602.13755.9.camel@gmail.com \
--to=umgwanakikbuti@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).