From: Luiz Capitulino <lcapitulino@redhat.com>
To: linux-rt-users@vger.kernel.org
Cc: williams@redhat.com, jkacur@redhat.com
Subject: [PATCH 3/4] don't use exit(-1) for failures
Date: Wed, 24 Feb 2016 15:49:40 -0500 [thread overview]
Message-ID: <1456346981-24032-4-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1456346981-24032-1-git-send-email-lcapitulino@redhat.com>
The kernel uses only 8 bits of the status as a return
code, so this actually becomes 255 in the shell.
In any case, the most widely convension is exit(1)
for failures, so let's be consistent.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
src/pi_tests/pi_stress.c | 2 +-
src/pi_tests/pip_stress.c | 6 +++---
src/rt-migrate-test/rt-migrate-test.c | 8 ++++----
src/signaltest/signaltest.c | 2 +-
4 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/pi_tests/pi_stress.c b/src/pi_tests/pi_stress.c
index aaa36c3..574fb65 100644
--- a/src/pi_tests/pi_stress.c
+++ b/src/pi_tests/pi_stress.c
@@ -634,7 +634,7 @@ int verify_cpu(int cpu)
if (status == -1) {
err = errno;
fprintf(stderr, "sched_getaffinity %s\n", strerror(err));
- exit(-1);
+ exit(1);
}
if (CPU_ISSET(cpu, &mask))
diff --git a/src/pi_tests/pip_stress.c b/src/pi_tests/pip_stress.c
index 812a703..bef1f92 100644
--- a/src/pi_tests/pip_stress.c
+++ b/src/pi_tests/pip_stress.c
@@ -95,7 +95,7 @@ int main(void)
*minimum_priority = sched_get_priority_min(policy);
if (check_privs())
- exit(-1);
+ exit(1);
mptr = mmap_page(); /* Get a page of shared memory */
resource = (pthread_mutex_t*)mptr; /* point our lock to it */
@@ -138,7 +138,7 @@ int main(void)
pid2 = fork(); /* parent code */
if (pid2 == -1) {
perror("fork: ");
- exit(-1);
+ exit(1);
} else if (pid2 != 0) { /* parent code */
high(pid2);
} else { /* child code */
@@ -231,7 +231,7 @@ void *mmap_page(void)
mptr = mmap(NULL, pgsize, PROTRW, MMAP_FLAGS, 0, 0);
if (mptr == MAP_FAILED) {
perror("In function mmap_page - mmap");
- exit(-1);
+ exit(1);
}
return mptr;
diff --git a/src/rt-migrate-test/rt-migrate-test.c b/src/rt-migrate-test/rt-migrate-test.c
index 6e8acc2..4a7ecbb 100644
--- a/src/rt-migrate-test/rt-migrate-test.c
+++ b/src/rt-migrate-test/rt-migrate-test.c
@@ -141,7 +141,7 @@ static void perr(char *fmt, ...)
perror(buffer);
fflush(stderr);
- exit(-1);
+ exit(1);
}
static void print_progress_bar(int percent)
@@ -228,11 +228,11 @@ static void parse_options (int argc, char *argv[])
}
if (nr_runs <= 0) {
fprintf(stderr, "Error: --loops argument is non-positive. Exiting.\n");
- exit(-1);
+ exit(1);
}
if (prio_start < 1 || prio_start > 99) {
fprintf(stderr, "Error: invalid value for --prio: %d (valid: 1-99)\n", prio_start);
- exit(-1);
+ exit(1);
}
}
@@ -599,7 +599,7 @@ int main (int argc, char **argv)
exit(2);
}
if (check < 0)
- exit(-1);
+ exit(1);
else
exit(0);
diff --git a/src/signaltest/signaltest.c b/src/signaltest/signaltest.c
index 9454a26..7eaceec 100644
--- a/src/signaltest/signaltest.c
+++ b/src/signaltest/signaltest.c
@@ -318,7 +318,7 @@ int main(int argc, char **argv)
int i, ret = -1;
if (check_privs())
- exit(-1);
+ exit(1);
process_options(argc, argv);
--
2.1.0
next prev parent reply other threads:[~2016-02-24 20:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 20:49 [PATCH 0/4] rt-tests: minor fixes Luiz Capitulino
2016-02-24 20:49 ` [PATCH 1/4] pip_stress: drop unused variable Luiz Capitulino
2016-03-16 22:00 ` John Kacur
2016-03-17 13:22 ` Luiz Capitulino
2016-02-24 20:49 ` [PATCH 2/4] rt-migrate-test: fix return code Luiz Capitulino
2016-03-16 22:14 ` John Kacur
2016-03-17 13:25 ` Luiz Capitulino
2016-02-24 20:49 ` Luiz Capitulino [this message]
2016-03-16 22:19 ` [PATCH 3/4] don't use exit(-1) for failures John Kacur
2016-02-24 20:49 ` [PATCH 4/4] cyclictest: initialize 'stop' early Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456346981-24032-4-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).