From: Luiz Capitulino <lcapitulino@redhat.com>
To: linux-rt-users@vger.kernel.org
Cc: jkacur@redhat.com, williams@redhat.com
Subject: [PATCH 3/4] cyclictest: move tracemark_fd handling to its own function
Date: Thu, 25 Feb 2016 11:29:16 -0500 [thread overview]
Message-ID: <1456417757-13444-4-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1456417757-13444-1-git-send-email-lcapitulino@redhat.com>
A function added by the next commit will want to call
this code too.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
src/cyclictest/cyclictest.c | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index f543c34..e35088b 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c
@@ -497,6 +497,19 @@ static void debugfs_prepare(void)
fileprefix = procfileprefix;
}
+static void open_tracemark_fd(void)
+{
+ char path[MAX_PATH];
+
+ if (tracemark_fd >= 0)
+ return;
+
+ sprintf(path, "%s/%s", fileprefix, "trace_marker");
+ tracemark_fd = open(path, O_WRONLY);
+ if (tracemark_fd < 0)
+ warn("unable to open trace_marker file: %s\n", path);
+}
+
static void setup_tracer(void)
{
if (!tracelimit || notrace)
@@ -612,14 +625,7 @@ static void setup_tracer(void)
fatal("unable to open %s for tracing", path);
}
- /* open the tracemark file descriptor */
- if (tracemark_fd == -1) {
- char path[MAX_PATH];
- strcat(strcpy(path, fileprefix), "trace_marker");
- if ((tracemark_fd = open(path, O_WRONLY)) == -1)
- warn("unable to open trace_marker file: %s\n", path);
- }
next prev parent reply other threads:[~2016-02-25 16:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 16:29 [PATCH 0/4] cyclictest: improve running under trace-cmd Luiz Capitulino
2016-02-25 16:29 ` [PATCH 1/4] cyclictest: tracing(): check for notrace Luiz Capitulino
2016-02-25 16:29 ` [PATCH 2/4] cyclictest: move debugfs init code to its own function Luiz Capitulino
2016-02-25 16:29 ` Luiz Capitulino [this message]
2016-02-25 16:29 ` [PATCH 4/4] cyclictest: add --tracemark option Luiz Capitulino
2016-03-16 21:23 ` [PATCH 0/4] cyclictest: improve running under trace-cmd Luiz Capitulino
2016-03-16 22:37 ` John Kacur
2016-03-17 13:48 ` Luiz Capitulino
-- strict thread matches above, loose matches on Subject: below --
2016-03-17 18:30 [PATCH v2 " Luiz Capitulino
2016-03-17 18:30 ` [PATCH 3/4] cyclictest: move tracemark_fd handling to its own function Luiz Capitulino
2016-03-22 14:35 ` John Kacur
2016-03-22 14:42 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456417757-13444-4-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).