From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-rt-users <linux-rt-users@vger.kernel.org>
Subject: [patch] rt,workqueue: Fix blocking call when !TASK_RUNNING splat in rescuer_thread()
Date: Sat, 27 Feb 2016 08:05:55 +0100 [thread overview]
Message-ID: <1456556755.3759.4.camel@gmail.com> (raw)
[ 0.221225] ------------[ cut here ]------------
[ 0.221241] WARNING: CPU: 1 PID: 69 at kernel/sched/core.c:7733 __might_sleep+0x7f/0x90()
[ 0.221253] do not call blocking ops when !TASK_RUNNING; state=1 set at [<ffffffff8106edc4>] rescuer_thread+0x64/0x340
[ 0.221263] Modules linked in:
[ 0.221272] CPU: 1 PID: 69 Comm: khelper Not tainted 4.0.0-rt4-lockdep #71
[ 0.221273] Hardware name: IBM System x3550 M3 -[7944K3G]-/69Y5698 , BIOS -[D6E150AUS-1.10]- 12/15/2010
[ 0.221280] ffffffff81a2269f ffff8801789a7cc8 ffffffff81605182 0000000000000002
[ 0.221282] ffff8801789a7d18 ffff8801789a7d08 ffffffff81053cda ffff8801789a7d48
[ 0.221284] ffffffff81a23b44 0000000000000394 0000000000000000 0000000000000000
[ 0.221284] Call Trace:
[ 0.221288] [<ffffffff81605182>] dump_stack+0x4f/0x9d
[ 0.221291] [<ffffffff81053cda>] warn_slowpath_common+0x8a/0xe0
[ 0.221293] [<ffffffff81053d76>] warn_slowpath_fmt+0x46/0x50
[ 0.221295] [<ffffffff8106edc4>] ? rescuer_thread+0x64/0x340
[ 0.221296] [<ffffffff8106edc4>] ? rescuer_thread+0x64/0x340
[ 0.221298] [<ffffffff810794ef>] __might_sleep+0x7f/0x90
[ 0.221299] [<ffffffff8106ed60>] ? worker_thread+0x4d0/0x4d0
[ 0.221301] [<ffffffff8160b4d4>] rt_spin_lock+0x24/0x70
[ 0.221304] [<ffffffff8107fddd>] ? migrate_disable+0x7d/0xe0
[ 0.221305] [<ffffffff8106ee09>] rescuer_thread+0xa9/0x340
[ 0.221307] [<ffffffff8106ed60>] ? worker_thread+0x4d0/0x4d0
[ 0.221308] [<ffffffff8106ed60>] ? worker_thread+0x4d0/0x4d0
[ 0.221311] [<ffffffff81073721>] kthread+0xe1/0x100
[ 0.221312] [<ffffffff8160b1e0>] ? _raw_spin_unlock_irq+0x30/0x70
[ 0.221315] [<ffffffff81073640>] ? __kthread_parkme+0xa0/0xa0
[ 0.221317] [<ffffffff8160be88>] ret_from_fork+0x58/0x90
[ 0.221319] [<ffffffff81073640>] ? __kthread_parkme+0xa0/0xa0
[ 0.221320] ---[ end trace 0000000000000001 ]---
Signed-off-by: Mike Galbraith <umgwanakikbuti@gmail.com>
---
kernel/workqueue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -2255,8 +2255,6 @@ static int rescuer_thread(void *__rescue
*/
rescuer->task->flags |= PF_WQ_WORKER;
repeat:
- set_current_state(TASK_INTERRUPTIBLE);
next reply other threads:[~2016-02-27 7:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 7:05 Mike Galbraith [this message]
2016-02-27 7:09 ` [patch] drm,radeon,i915: use preempt_disable/enable_rt() where recommended Mike Galbraith
2016-02-27 7:34 ` [patch] locking/lglocks: use preempt_enable/disable_nort() in lg_double_lock/lg_double_unlock Mike Galbraith
2016-02-27 8:01 ` [patch] drm,i915: Use local_lock/unlock_irq() in intel_pipe_update_start/end() Mike Galbraith
2016-02-27 9:04 ` [patch] rt,workqueue: Fix blocking call when !TASK_RUNNING splat in rescuer_thread() Thomas Gleixner
2016-02-27 9:14 ` Thomas Gleixner
2016-02-27 9:16 ` Thomas Gleixner
2016-02-27 12:11 ` Mike Galbraith
2016-02-27 13:48 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456556755.3759.4.camel@gmail.com \
--to=umgwanakikbuti@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).