* [PATCH] sched: Fix compile warning when using CONFIG_PREEMPT_NONE
@ 2016-06-29 16:55 minyard
2016-07-29 15:46 ` Sebastian Andrzej Siewior
0 siblings, 1 reply; 3+ messages in thread
From: minyard @ 2016-06-29 16:55 UTC (permalink / raw)
To: linux-rt-users, Steven Rostedt; +Cc: Corey Minyard
From: Corey Minyard <cminyard@mvista.com>
preemptible_lazy() is only used under CONFIG_PREEMPT, but it was
always defined. Move it into a CONFIG_PREEMPT ifdef.
Signed-off-by: Corey Minyard <cminyard@mvista.com>
---
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index f3130a8..57af106 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3454,6 +3454,7 @@ static void __sched notrace preempt_schedule_common(void)
} while (need_resched());
}
+#ifdef CONFIG_PREEMPT
#ifdef CONFIG_PREEMPT_LAZY
/*
* If TIF_NEED_RESCHED is then we allow to be scheduled away since this is
@@ -3478,7 +3479,6 @@ static int preemptible_lazy(void)
#endif
-#ifdef CONFIG_PREEMPT
/*
* this is the entry point to schedule() from in-kernel preemption
* off of preempt_enable. Kernel preemptions off return from interrupt
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sched: Fix compile warning when using CONFIG_PREEMPT_NONE
2016-06-29 16:55 [PATCH] sched: Fix compile warning when using CONFIG_PREEMPT_NONE minyard
@ 2016-07-29 15:46 ` Sebastian Andrzej Siewior
2016-07-29 17:49 ` Corey Minyard
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Andrzej Siewior @ 2016-07-29 15:46 UTC (permalink / raw)
To: minyard; +Cc: linux-rt-users, Steven Rostedt, Corey Minyard
* minyard@acm.org | 2016-06-29 11:55:11 [-0500]:
>From: Corey Minyard <cminyard@mvista.com>
>
>preemptible_lazy() is only used under CONFIG_PREEMPT, but it was
>always defined. Move it into a CONFIG_PREEMPT ifdef.
Oh sorry, I missed that one but the problem is gone, right?
Sebastian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sched: Fix compile warning when using CONFIG_PREEMPT_NONE
2016-07-29 15:46 ` Sebastian Andrzej Siewior
@ 2016-07-29 17:49 ` Corey Minyard
0 siblings, 0 replies; 3+ messages in thread
From: Corey Minyard @ 2016-07-29 17:49 UTC (permalink / raw)
To: Sebastian Andrzej Siewior, minyard; +Cc: linux-rt-users, Steven Rostedt
On 07/29/2016 10:46 AM, Sebastian Andrzej Siewior wrote:
> * minyard@acm.org | 2016-06-29 11:55:11 [-0500]:
>
>> From: Corey Minyard <cminyard@mvista.com>
>>
>> preemptible_lazy() is only used under CONFIG_PREEMPT, but it was
>> always defined. Move it into a CONFIG_PREEMPT ifdef.
> Oh sorry, I missed that one but the problem is gone, right?
>
> Sebastian
Yes, it appears to be gone. Before I think you could define
CONFIG_PREEMPT_LAZY
without CONFIG_PREEMPT being defined.
-corey
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-29 17:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-29 16:55 [PATCH] sched: Fix compile warning when using CONFIG_PREEMPT_NONE minyard
2016-07-29 15:46 ` Sebastian Andrzej Siewior
2016-07-29 17:49 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).