From: Mike Galbraith <efault@gmx.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: [patch-rt] softirq: Move ksoftirqd_running() under !CONFIG_PREEMPT_RT_FULL
Date: Sat, 31 Dec 2016 09:20:10 +0100 [thread overview]
Message-ID: <1483172410.9872.2.camel@gmx.de> (raw)
In-Reply-To: <20161223163213.szj43nv7rnelkbty@linutronix.de>
Otherwise, ktimersoftd may not be awakened when it has work to do.
[ 84.087571] NOHZ: local_softirq_pending 02
[ 84.087593] NOHZ: local_softirq_pending 02
[ 84.087598] NOHZ: local_softirq_pending 02
[ 84.087904] NOHZ: local_softirq_pending 02
[ 84.088526] NOHZ: local_softirq_pending 02
[ 84.088899] NOHZ: local_softirq_pending 02
[ 84.089463] NOHZ: local_softirq_pending 02
[ 115.013470] NOHZ: local_softirq_pending 02
[ 115.013601] NOHZ: local_softirq_pending 02
[ 115.013709] NOHZ: local_softirq_pending 02
Signed-off-by: Mike Galbraith <efault@gmx.de>
---
kernel/softirq.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -206,6 +206,7 @@ static void handle_softirq(unsigned int
}
}
+#ifndef CONFIG_PREEMPT_RT_FULL
/*
* If ksoftirqd is scheduled, we do not want to process pending softirqs
* right now. Let ksoftirqd handle this at its own rate, to get fairness.
@@ -217,7 +218,6 @@ static bool ksoftirqd_running(void)
return tsk && (tsk->state == TASK_RUNNING);
}
-#ifndef CONFIG_PREEMPT_RT_FULL
static inline int ksoftirqd_softirq_pending(void)
{
return local_softirq_pending();
@@ -794,13 +794,10 @@ void irq_enter(void)
static inline void invoke_softirq(void)
{
-#ifdef CONFIG_PREEMPT_RT_FULL
- unsigned long flags;
-#endif
-
+#ifndef CONFIG_PREEMPT_RT_FULL
if (ksoftirqd_running())
return;
-#ifndef CONFIG_PREEMPT_RT_FULL
+
if (!force_irqthreads) {
#ifdef CONFIG_HAVE_IRQ_EXIT_ON_IRQ_STACK
/*
@@ -821,6 +818,7 @@ static inline void invoke_softirq(void)
wakeup_softirqd();
}
#else /* PREEMPT_RT_FULL */
+ unsigned long flags;
local_irq_save(flags);
if (__this_cpu_read(ksoftirqd) &&
next prev parent reply other threads:[~2016-12-31 8:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 16:32 [ANNOUNCE] v4.9-rt1 Sebastian Andrzej Siewior
2016-12-26 6:54 ` [patch-rt] kvm: Convert pvclock_gtod_sync_lock to raw_spinlock_t Mike Galbraith
2017-01-20 16:44 ` Sebastian Andrzej Siewior
2017-01-20 17:32 ` Mike Galbraith
2016-12-26 7:00 ` [rfc patch-rt] posix_cpu_timers: Kill hotplug cpu notifier Mike Galbraith
2017-01-20 16:46 ` Sebastian Andrzej Siewior
2017-01-20 17:29 ` Mike Galbraith
2017-01-20 17:34 ` Sebastian Andrzej Siewior
2017-01-20 17:56 ` Mike Galbraith
2016-12-31 8:20 ` Mike Galbraith [this message]
2017-01-20 17:21 ` [patch-rt] softirq: Move ksoftirqd_running() under !CONFIG_PREEMPT_RT_FULL Sebastian Andrzej Siewior
2017-01-06 8:13 ` [rfc patch-rt] radix-tree: Partially disable memcg accounting in radix_tree_node_alloc() Mike Galbraith
2017-01-06 8:28 ` Mike Galbraith
2017-01-06 8:55 ` Michal Hocko
2017-01-06 10:52 ` Mike Galbraith
2017-01-06 12:20 ` Mike Galbraith
2017-01-06 12:44 ` Mike Galbraith
2017-01-25 15:06 ` Sebastian Andrzej Siewior
2017-01-26 3:42 ` Mike Galbraith
2017-01-08 8:32 ` {patch-rt] cpuset: Convert callback_lock to raw_spinlock_t Mike Galbraith
2017-01-25 15:45 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483172410.9872.2.camel@gmx.de \
--to=efault@gmx.de \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).