From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [btrfs/rt] lockdep false positive
Date: Mon, 23 Jan 2017 06:23:23 +0100 [thread overview]
Message-ID: <1485149003.4554.74.camel@gmail.com> (raw)
In-Reply-To: <1485107114.4467.73.camel@gmail.com>
On Sun, 2017-01-22 at 18:45 +0100, Mike Galbraith wrote:
> On Sun, 2017-01-22 at 09:46 +0100, Mike Galbraith wrote:
> > Greetings btrfs/lockdep wizards,
> >
> > RT trees have trouble with the BTRFS lockdep positive avoidance lock
> > class dance (see disk-io.c). Seems the trouble is due to RT not having
> > a means of telling lockdep that its rwlocks are recursive for read by
> > the lock owner only, combined with the BTRFS lock class dance assuming
> > that read_lock() is annotated rwlock_acquire_read(), which RT cannot
> > do, as that would be a big fat lie.
> >
> > Creating a rt_read_lock_shared() for btrfs_clear_lock_blocking_rw() did
> > indeed make lockdep happy as a clam for test purposes. (hm, submitting
> > that would be excellent way to replenish frozen shark supply:)
> >
> > Ideas?
>
> Hrm. The below seems to work fine, but /me strongly suspects that if
> it were this damn trivial, the issue would be long dead.
(iow, did I merely spell '2' as '3' vs creating the annotation I want)
next prev parent reply other threads:[~2017-01-23 5:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 8:46 [btrfs/rt] lockdep false positive Mike Galbraith
2017-01-22 17:45 ` Mike Galbraith
2017-01-22 18:25 ` Mike Galbraith
2017-01-23 5:23 ` Mike Galbraith [this message]
2017-01-23 9:07 ` Peter Zijlstra
2017-01-25 17:02 ` Sebastian Andrzej Siewior
2017-01-25 18:29 ` Mike Galbraith
2017-01-26 17:09 ` Sebastian Andrzej Siewior
2017-01-26 18:01 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485149003.4554.74.camel@gmail.com \
--to=umgwanakikbuti@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).