From: Mike Galbraith <efault@gmx.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: [patch-rt v2] rtmutex: Fix lock stealing logic
Date: Fri, 23 Jun 2017 16:07:19 +0200 [thread overview]
Message-ID: <1498226839.31539.13.camel@gmx.de> (raw)
In-Reply-To: <20170623093341.547ce155@gandalf.local.home>
On Fri, 2017-06-23 at 09:33 -0400, Steven Rostedt wrote:
> struct task_struct *task,
> > @@ -886,20 +901,16 @@ static int __try_to_take_rt_mutex(struct
> > */
> > if (waiter) {
> > /*
> > - * If waiter is not the highest priority waiter of
> > - * @lock, give up.
> > + * If waiter is not the highest priority waiter of @lock,
> > + * or its peer when lateral steal is allowed, give up.
> > */
> > - if (waiter != rt_mutex_top_waiter(lock)) {
> > - /* XXX rt_mutex_waiter_less() ? */
> > + if (!rt_mutex_steal(lock, waiter, mode))
> > return 0;
> > - }
> > -
> > /*
> > * We can acquire the lock. Remove the waiter from the
> > * lock waiters tree.
> > */
> > rt_mutex_dequeue(lock, waiter);
> > -
>
> I liked that space.
I like minus signs in diffstat, that one was a freebee. Maintainers
can revive it if they like, or I can post a V3 with it revived as well
as s/rt_mutex_steal/rt_mutex_claim.
-Mike
next prev parent reply other threads:[~2017-06-23 14:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 10:56 [ANNOUNCE] v4.11.5-rt1 Sebastian Andrzej Siewior
2017-06-17 8:14 ` Mike Galbraith
2017-06-18 6:46 ` Mike Galbraith
2017-06-19 8:52 ` Sebastian Andrzej Siewior
2017-06-19 10:14 ` Mike Galbraith
2017-06-19 10:44 ` Sebastian Andrzej Siewior
2017-06-19 11:31 ` Mike Galbraith
2017-06-19 11:50 ` Sebastian Andrzej Siewior
2017-06-19 12:55 ` Mike Galbraith
2017-06-19 14:06 ` Sebastian Andrzej Siewior
2017-06-19 14:36 ` Mike Galbraith
2017-06-19 15:03 ` Sebastian Andrzej Siewior
2017-06-19 16:14 ` Mike Galbraith
2017-06-19 16:27 ` Sebastian Andrzej Siewior
2017-06-19 16:46 ` Mike Galbraith
2017-06-19 14:08 ` Steven Rostedt
2017-06-19 14:13 ` Sebastian Andrzej Siewior
2017-06-19 14:41 ` Steven Rostedt
2017-06-19 16:29 ` Mike Galbraith
2017-06-20 7:45 ` Mike Galbraith
2017-06-22 16:34 ` Sebastian Andrzej Siewior
2017-06-22 17:30 ` Mike Galbraith
2017-06-22 21:36 ` Thomas Gleixner
2017-06-23 2:00 ` Mike Galbraith
2017-06-23 12:48 ` Sebastian Andrzej Siewior
2017-06-18 17:01 ` [patch-rt] rtmutex: Fix lock stealing logic Mike Galbraith
2017-06-23 7:37 ` [patch-rt v2] " Mike Galbraith
2017-06-23 10:07 ` Mike Galbraith
2017-06-26 13:47 ` Sebastian Andrzej Siewior
2017-06-23 13:33 ` Steven Rostedt
2017-06-23 14:07 ` Mike Galbraith [this message]
2017-06-23 14:14 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498226839.31539.13.camel@gmx.de \
--to=efault@gmx.de \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).