From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: linux-rt-users-owner@vger.kernel.org
Received: from mail.kernel.org ([198.145.29.99]:38454 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725870AbeHNXrO (ORCPT <rfc822;linux-rt-users@vger.kernel.org>);
        Tue, 14 Aug 2018 19:47:14 -0400
Message-ID: <1534280294.30734.2.camel@kernel.org>
Subject: Re: [PATCH 09/15] squashfs: make use of local lock in multi_cpu
 decompressor
From: Tom Zanussi <zanussi@kernel.org>
Date: Tue, 14 Aug 2018 15:58:14 -0500
In-Reply-To: <20180814203621.GA9506@jcartwri.amer.corp.natinst.com>
References: <cover.1534263273.git.tom.zanussi@linux.intel.com>
         <37654199e62d7092f0da75e87841dfe82dda483f.1534263273.git.tom.zanussi@linux.intel.com>
         <20180814203621.GA9506@jcartwri.amer.corp.natinst.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-rt-users-owner@vger.kernel.org
List-ID: <linux-rt-users.vger.kernel.org>
To: Julia Cartwright <julia@ni.com>
Cc: linux-rt-users@vger.kernel.org, rostedt@goodmis.org, tglx@linutronix.de, C.Emde@osadl.org, jkacur@redhat.com, bigeasy@linutronix.de, daniel.wagner@siemens.com

Hi Julia,

On Tue, 2018-08-14 at 15:36 -0500, Julia Cartwright wrote:
> Hey Tom-
> 
> On Tue, Aug 14, 2018 at 01:54:02PM -0500, Tom Zanussi wrote:
> > v3.18.117-rt105 rt-stable review patch.  If anyone has any
> > objections,
> > please let me know.
> > 
> > ------------------
> > 
> > From: Julia Cartwright <julia@ni.com>
> > 
> > [ Upstream rt-devel commit c160736542d7b3d67da32848d2f028b8e35730e5
> > ]
> > 
> > Currently, the squashfs multi_cpu decompressor makes use of
> > get_cpu_ptr()/put_cpu_ptr(), which unconditionally disable
> > preemption
> > during decompression.
> > 
> > Because the workload is distributed across CPUs, all CPUs can
> > observe a
> > very high wakeup latency, which has been seen to be as much as
> > 8000us.
> > 
> > Convert this decompressor to make use of a local lock, which will
> > allow
> > execution of the decompressor with preemption-enabled, but also
> > ensure
> > concurrent accesses to the percpu compressor data on the local CPU
> > will
> > be serialized.
> > 
> > Cc: stable-rt@vger.kernel.org
> > Reported-by: Alexander Stein <alexander.stein@systec-electronic.com
> > >
> > Tested-by: Alexander Stein <alexander.stein@systec-electronic.com>
> > Signed-off-by: Julia Cartwright <julia@ni.com>
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> > ---
> 
> [..]
> >  void *squashfs_decompressor_create(struct squashfs_sb_info *msblk,
> >  						void *comp_opts)
> >  {
> > @@ -79,10 +82,15 @@ int squashfs_decompress(struct squashfs_sb_info
> > *msblk, struct buffer_head **bh,
> >  {
> >  	struct squashfs_stream __percpu *percpu =
> >  			(struct squashfs_stream __percpu *) msblk-
> > >stream;
> > -	struct squashfs_stream *stream = get_cpu_ptr(percpu);
> > -	int res = msblk->decompressor->decompress(msblk, stream-
> > >stream, bh, b,
> > -		offset, length, output);
> > -	put_cpu_ptr(stream);
> > +	struct squashfs_stream *stream;
> > +	int res;
> > +
> > +	stream = get_locked_ptr(stream_lock, percpu);
> 
> This patch depends on the introduction of the {get,put}_locked_ptr()
> per-cpu access variants.  So, you'll want to also pull commit
> 
>  3d45cf23db4f76cd3 ("locallock: provide {get,put}_locked_ptr()
> variants")
> 
> From rt-devel as well.
> 

Yep, missed that one - thought I had squashfs enabled, sigh.  Thanks
for pointing that out, Julia.

Tom