From: Tom Zanussi <zanussi@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: rostedt@goodmis.org, tglx@linutronix.de, namhyung@kernel.org,
vedang.patel@intel.com, bigeasy@linutronix.de,
joel@joelfernandes.org, mathieu.desnoyers@efficios.com,
julia@ni.com, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org
Subject: Re: [PATCH v5 7/8] tracing: Add hist trigger onchange() handler
Date: Tue, 02 Oct 2018 10:35:47 -0500 [thread overview]
Message-ID: <1538494547.16568.1.camel@kernel.org> (raw)
In-Reply-To: <20181002165309.da3d63365ca774cf6b47b80c@kernel.org>
Hi Masami,
On Tue, 2018-10-02 at 16:53 +0900, Masami Hiramatsu wrote:
> On Mon, 1 Oct 2018 11:18:07 -0500
> Tom Zanussi <zanussi@kernel.org> wrote:
>
> > From: Tom Zanussi <tom.zanussi@linux.intel.com>
> >
> > Add support for a hist:onchange($var) handler, similar to the
> > onmax()
> > handler but triggering whenever there's any change in $var, not
> > just a
> > max.
> >
> > Also, add a testcase for it.
>
> Could you separate the testcase and document update from this patch,
> since those are maintained in different trees?
>
OK, will do.
> And also, could you update <tracefs>/README so that the testcase can
> ensure the kernel supports this feature? Since the testcase
> (kselftest)
> will be used for stable kernels, it should check the kernel carefully
> and exit with "unsupported" instead of failure.
>
Yeah, makes sense, will add that check.
Thanks,
Tom
next prev parent reply other threads:[~2018-10-02 15:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 16:18 [PATCH v5 0/8] tracing: Hist trigger snapshot and onchange additions Tom Zanussi
2018-10-01 16:18 ` [PATCH v5 1/8] tracing: Refactor hist trigger action code Tom Zanussi
2018-10-01 16:18 ` [PATCH v5 2/8] tracing: Split up onmatch action data Tom Zanussi
2018-10-01 16:18 ` [PATCH v5 3/8] tracing: Generalize hist trigger onmax and save action Tom Zanussi
2018-10-01 16:18 ` [PATCH v5 4/8] tracing: Add conditional snapshot Tom Zanussi
2018-10-01 16:18 ` [PATCH v5 5/8] tracing: Move hist trigger key printing into a separate function Tom Zanussi
2018-10-01 16:18 ` [PATCH v5 6/8] tracing: Add snapshot action Tom Zanussi
2018-10-01 16:18 ` [PATCH v5 7/8] tracing: Add hist trigger onchange() handler Tom Zanussi
2018-10-02 7:53 ` Masami Hiramatsu
2018-10-02 15:35 ` Tom Zanussi [this message]
2018-10-01 16:18 ` [PATCH v5 8/8] trace: Add alternative synthetic event trace action syntax Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538494547.16568.1.camel@kernel.org \
--to=zanussi@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=joel@joelfernandes.org \
--cc=julia@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vedang.patel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).