From: Tom Zanussi <zanussi@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: tglx@linutronix.de, mhiramat@kernel.org, namhyung@kernel.org,
vedang.patel@intel.com, bigeasy@linutronix.de,
joel@joelfernandes.org, mathieu.desnoyers@efficios.com,
julia@ni.com, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org
Subject: Re: [PATCH v14 06/15] tracing: Add hist trigger snapshot() action
Date: Wed, 13 Feb 2019 13:47:19 -0600 [thread overview]
Message-ID: <1550087239.7529.1.camel@kernel.org> (raw)
In-Reply-To: <20190213143523.1e387566@gandalf.local.home>
Hi Steve,
On Wed, 2019-02-13 at 14:35 -0500, Steven Rostedt wrote:
> On Wed, 13 Feb 2019 14:25:51 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > I noticed this because we hardcode the size in memcpy. Should hard
> > code
> > it above, otherwise it looks like elt_data->comm may be something
> > other
> > than TASK_COMM_LEN.
>
>
> Hi Tom,
>
> My comments on patch 5 and 6 are the only comments I have on the
> series. Could you address them and post a v15, and I'll pull them in
> and start testing them?
>
Great, yeah I'll make all those changes and post a v15 shortly.
Thanks,
Tom
> Thanks!
>
> -- Steve
next prev parent reply other threads:[~2019-02-13 19:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 22:41 [PATCH v14 00/15] tracing: Hist trigger snapshot and onchange additions Tom Zanussi
2019-02-05 22:41 ` [PATCH v14 01/15] tracing: Refactor hist trigger action code Tom Zanussi
2019-02-05 22:41 ` [PATCH v14 02/15] tracing: Make hist trigger Documentation better reflect actions/handlers Tom Zanussi
2019-02-05 22:41 ` [PATCH v14 03/15] tracing: Split up onmatch action data Tom Zanussi
2019-02-05 22:41 ` [PATCH v14 04/15] tracing: Generalize hist trigger onmax and save action Tom Zanussi
2019-02-05 22:41 ` [PATCH v14 05/15] tracing: Add conditional snapshot Tom Zanussi
2019-02-13 19:18 ` Steven Rostedt
2019-02-05 22:41 ` [PATCH v14 06/15] tracing: Add hist trigger snapshot() action Tom Zanussi
2019-02-13 19:25 ` Steven Rostedt
2019-02-13 19:35 ` Steven Rostedt
2019-02-13 19:47 ` Tom Zanussi [this message]
2019-02-05 22:41 ` [PATCH v14 07/15] tracing: Add hist trigger snapshot() action Documentation Tom Zanussi
2019-02-05 22:41 ` [PATCH v14 08/15] tracing: Add hist trigger onchange() handler Tom Zanussi
2019-02-05 22:41 ` [PATCH v14 09/15] tracing: Add hist trigger onchange() handler Documentation Tom Zanussi
2019-02-05 22:41 ` [PATCH v14 10/15] tracing: Add alternative synthetic event trace action syntax Tom Zanussi
2019-02-05 22:41 ` [PATCH v14 11/15] tracing: Add SPDX license GPL-2.0 license identifier to inter-event testcases Tom Zanussi
2019-02-05 22:41 ` [PATCH v14 12/15] tracing: Add hist trigger snapshot() action test case Tom Zanussi
2019-02-05 22:41 ` [PATCH v14 13/15] tracing: Add hist trigger onchange() handler " Tom Zanussi
2019-02-05 22:42 ` [PATCH v14 14/15] tracing: Add alternative synthetic event trace action " Tom Zanussi
2019-02-05 22:42 ` [PATCH v14 15/15] tracing: Add hist trigger action 'expected fail' " Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550087239.7529.1.camel@kernel.org \
--to=zanussi@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=joel@joelfernandes.org \
--cc=julia@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vedang.patel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).