From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A8CBC43381 for ; Tue, 12 Mar 2019 16:49:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 294882087C for ; Tue, 12 Mar 2019 16:49:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552409359; bh=QYO7095VXhN8T7/S5iYO2zw8ve4VvoBBWYaGoy3r5QQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References:List-ID:From; b=jgXDM12KxE/s97uhcW6MvLP51mfGMrGDT/ex6GE3RfTbg+OdIF5CVPAL8KXFjzkTo 94ZZoIHt7O7fvE41ARwfVLTCV2ZyZptv3C766oz7bLtBAfalRP+Osu2KR29SM5XI3L OVnIZ9Fw2xyCxwINA+ED0HDo3WjgyTeMCOwtelOc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726849AbfCLQtO (ORCPT ); Tue, 12 Mar 2019 12:49:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:56652 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726141AbfCLQtO (ORCPT ); Tue, 12 Mar 2019 12:49:14 -0400 Received: from tzanussi-mobl (c-98-220-238-81.hsd1.il.comcast.net [98.220.238.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 33F1D2054F; Tue, 12 Mar 2019 16:49:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552409352; bh=QYO7095VXhN8T7/S5iYO2zw8ve4VvoBBWYaGoy3r5QQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=XcUt67iPp7Byf1rW5+givNZsHfolOn/iIVRnmPRQQlgQ3ee0yVE4+y7QaYOoaMUtB xO6Y7aMrSGym1B/C2c4YUhfiAFI0WCwiDxXzzy+Gt8hh/IijUb9/TzOqok5IgDFY8s N92tBQZbR5IDjn0XzDai+WtRhYPNgRJn3rYxvjd8= Message-ID: <1552409351.4293.22.camel@kernel.org> Subject: Re: [RFC PATCH v3 0/5] tracing: common error_log for ftrace From: Tom Zanussi To: Masami Hiramatsu Cc: rostedt@goodmis.org, tglx@linutronix.de, namhyung@kernel.org, bigeasy@linutronix.de, joel@joelfernandes.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Date: Tue, 12 Mar 2019 11:49:11 -0500 In-Reply-To: <20190312152605.00150aae7b781137005e9ebf@kernel.org> References: <20190305230646.e7f99c46f86c0e099ac0cd30@kernel.org> <20190312152605.00150aae7b781137005e9ebf@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-rt-users-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rt-users@vger.kernel.org Hi Masami, On Tue, 2019-03-12 at 15:26 +0900, Masami Hiramatsu wrote: > Hi Tom, > > On Tue, 5 Mar 2019 23:06:46 +0900 > Masami Hiramatsu wrote: > > > On Mon, 4 Mar 2019 17:36:43 -0600 > > > Changes from v2: > > > > > > - Added [n] numbering as suggested by Masami > > Hmm, this seems a bit different what I suggested. > > I'm trying to port probe event's error report on > your error log, and I found that the number is > just shifted as below. > > When I filled the log with errors. > ============= > /sys/kernel/debug/tracing # cat error_log > [1] trace_kprobe: error: Invalid unsigned integer string > Command: r10aa00:foo/bar vfs > ^ > ... > > [7] trace_kprobe: error: Group name must follow C naming convention > Command: p:a-b/bar vfs_read > ^ > [8] trace_kprobe: error: Event name is too long > Command: > p:a/barrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr > rrrrrrrrrrr vfs_read > ============= > > And do one more error, > > ============= > /sys/kernel/debug/tracing # cat error_log > [1] trace_kprobe: error: Maxactive is too big > Command: r0xaa00:foo/bar vfs > > .... > > [7] trace_kprobe: error: Event name is too long > Command: > p:a/barrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr > rrrrrrrrrrr vfs_read > ^ > [8] trace_kprobe: error: Event name must follow C naming convention > Command: p:a/bar.c vfs_read > ^ > ============= > > The number of logs are changed :( This can confuse users. > I think it is better to keep the number as a unique number for > each entry as below. > Hmm, that makes sense, but I wonder if that will also confuse users, when the log wraps around and no longer starts at [1] and there's no way to retrieve the previous errors. I took your suggestion as a way mainly to clearly delineate each error, since without the [number] or something similar, they all kind of run together. Not sure what advantage numbering itself provides - would some other non-numbered separator work? Thanks, Tom > ============= > /sys/kernel/debug/tracing # cat error_log > [2] trace_kprobe: error: Maxactive is too big > Command: r0xaa00:foo/bar vfs > > .... > > [8] trace_kprobe: error: Event name is too long > Command: > p:a/barrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr > rrrrrrrrrrr vfs_read > ^ > [9] trace_kprobe: error: Event name must follow C naming convention > Command: p:a/bar.c vfs_read > ^ > ============= > > Thank you, >