From: Tom Zanussi <zanussi@kernel.org>
To: Daniel Wagner <daniel.wagner@siemens.com>
Cc: linux-rt-users <linux-rt-users@vger.kernel.org>
Subject: [PATCH] srt_create: Make sure series output is sorted
Date: Fri, 12 Apr 2019 12:31:39 -0500 [thread overview]
Message-ID: <1555090299.12566.35.camel@kernel.org> (raw)
Hi Daniel,
I actually used your stable-rt-tools srt tool this time to do the
latest 3.18-rt update release - overall it works well and did the job
nicely!
I did run into one serious problem in that the series file that gets
created for the patches tarball lists the patches in essentially random
order on my system, so using it to apply the series with quilt failed
immediately. The patch below fixes the problem for me.
There were a few other things I ran into which boiled down to
essentially lack of documentation and/or informative enough error
messages, and one or two things having to do with my workflow on two
separate machines that I'll have to think about. I'll write some
patches addressing those and sent when I get the chance.
Anyway, thanks for the useful tool!
Tom
--
From: Tom Zanussi <tom.zanussi@linux.intel.com>
os.listdir() doesn't guarantee ordering, so using its output directly
as input for the series file can result in a randomly ordered series
that quilt can't apply.
Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
---
srt_create.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srt_create.py b/srt_create.py
index 7314988..90d1e1b 100644
--- a/srt_create.py
+++ b/srt_create.py
@@ -47,7 +47,7 @@ def create_series(old_tag, new_tag, dirname):
cmd(['git', 'format-patch', '-q', '-o', dirname,
'{0}..{1}'.format(old_tag, new_tag)])
- patches = [f for f in os.listdir(dirname)
+ patches = [f for f in sorted(os.listdir(dirname))
if os.path.isfile(os.path.join(dirname, f))]
with open(dirname + '/series', 'w') as file:
for p in patches:
--
2.14.1
next reply other threads:[~2019-04-12 17:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 17:31 Tom Zanussi [this message]
2019-04-15 10:45 ` [PATCH] srt_create: Make sure series output is sorted Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1555090299.12566.35.camel@kernel.org \
--to=zanussi@kernel.org \
--cc=daniel.wagner@siemens.com \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).