From: Bhavesh Davda <bhavesh@vmware.com>
To: John Kacur <jkacur@redhat.com>
Cc: linux-rt-users@vger.kernel.org, frank rowand <frank.rowand@am.sony.com>
Subject: Re: [PATCH RT-TESTS] cyclictest: histogram overflow instance tracking
Date: Tue, 13 Nov 2012 16:17:32 -0800 (PST) [thread overview]
Message-ID: <186127385.49218418.1352852252623.JavaMail.root@vmware.com> (raw)
In-Reply-To: <CAONaPpHVRb6Uw8=6di1R5+ah7LPa8ztypYCoObAf25pfj2ajnA@mail.gmail.com>
No disrespect intended, sorry if it came across as such.
And as I'm no cyclictest expert, I didn't quite catch the subtleties of Frank's important observation. I'll need to study the cyclictest code more carefully to really grok that, which I will.
Stay tuned for a patch...
--
Bhavesh Davda
----- Original Message -----
> From: "John Kacur" <jkacur@redhat.com>
> To: "Bhavesh Davda" <bhavesh@vmware.com>
> Cc: linux-rt-users@vger.kernel.org, "frank rowand" <frank.rowand@am.sony.com>
> Sent: Tuesday, November 13, 2012 4:09:22 PM
> Subject: Re: [PATCH RT-TESTS] cyclictest: histogram overflow instance tracking
>
> On Wed, Nov 14, 2012 at 1:04 AM, Bhavesh Davda <bhavesh@vmware.com>
> wrote:
> > Okay, Frank's response raced with mine. Since Frank is not super
> > motivated to submit a patch with his proposed changes to my patch,
> > I'll do so.
> >
>
> Ummm, ok, this is sounding a little condescending. When people review
> your patch, this is a gift they gave you which they did not need to.
> It means they found your patch interesting enough to suggest how to
> make it better. Adding an option to turn it on, is trivial, I
> believe,
> the important point that Frank said is
>
> "One further thought... The histogram overflow cycle report shows
> what cycle the overflow occurred in, not the actual time. Adding
> the merged for all threads cycle times works because the histogram
> turns off the "different intervals for different threads" option:
>
> if (!histogram) /* same interval on CPUs */
> interval += distance;
>
> but if that ever changes then cycle is not a useful value to be
> reporting.
>
> So it seems like it would be useful to convert cycle to a time
> in the report. This is something that would have to be done
> anyway in post processing when trying to make use of the report."
>
> The motivation should belong to you. You should be proud that we
> thought your ideas were important and good enough to incorporate into
> the software and to review and comment on it. Careful there!
>
> Thanks
>
> John
>
next prev parent reply other threads:[~2012-11-14 0:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 17:02 [PATCH RT-TESTS] cyclictest: histogram overflow instance tracking Bhavesh Davda
2012-10-23 1:16 ` Frank Rowand
2012-10-23 1:41 ` Frank Rowand
2012-10-23 18:59 ` Bhavesh Davda
2012-10-23 19:25 ` John Kacur
2012-10-23 19:55 ` Frank Rowand
2012-10-23 19:59 ` Sven-Thorsten Dietrich
2012-10-25 21:36 ` Frank Rowand
2012-10-25 22:05 ` Frank Rowand
2012-11-13 23:41 ` Frank Rowand
2012-11-13 23:41 ` Frank Rowand
2012-11-13 23:48 ` Bhavesh Davda
2012-11-13 23:53 ` John Kacur
2012-11-14 0:02 ` Frank Rowand
2012-11-14 0:03 ` Bhavesh Davda
2012-11-14 0:04 ` Bhavesh Davda
2012-11-14 0:09 ` John Kacur
2012-11-14 0:17 ` Bhavesh Davda [this message]
2012-11-14 0:19 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=186127385.49218418.1352852252623.JavaMail.root@vmware.com \
--to=bhavesh@vmware.com \
--cc=frank.rowand@am.sony.com \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).