From: John Kacur <jkacur@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: linux-rt-users@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH v3] rt-numa: ignore runtime cpumask if -a CPULIST is specified
Date: Fri, 28 Jan 2022 16:11:51 -0500 (EST) [thread overview]
Message-ID: <18abab1-c454-bd62-ebab-6b5451ac3de@redhat.com> (raw)
In-Reply-To: <YfQ4f1CWDubRMlmA@fuller.cnet>
On Fri, 28 Jan 2022, Marcelo Tosatti wrote:
>
> When using isolcpus kernel command line option, the CPUs
> specified at isolcpus= are not part of the run time environment
> cpumask.
>
> This causes "cyclictest -a isolatedcpus" to fail with:
>
> WARN: Couldn't setaffinity in main thread: Invalid argument
> FATAL: No allowable cpus to run on
> # /dev/cpu_dma_latency set to 0us
>
> To fix this, ignore the runtime cpumask if neither "+", "!"
> are specified in the cpu list string.
>
> Suggested by Sebastian Andrzej Siewior.
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> v3: simplified version (John Kacur)
> v2: fix changelog typo
>
> diff --git a/src/lib/rt-numa.c b/src/lib/rt-numa.c
> index ee5ab99..3eead80 100644
> --- a/src/lib/rt-numa.c
> +++ b/src/lib/rt-numa.c
> @@ -131,7 +131,8 @@ int parse_cpumask(char *str, int max_cpus, struct bitmask **cpumask)
> return 0;
> }
>
> - use_current_cpuset(max_cpus, mask);
> + if (strchr(str, '!') != NULL || strchr(str, '+') != NULL)
> + use_current_cpuset(max_cpus, mask);
> *cpumask = mask;
>
> return 0;
>
>
Signed-off-by: John Kacur <jkacur@redhat.com>
prev parent reply other threads:[~2022-01-28 21:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 14:16 [PATCH] rt-numa: optionally ignore runtime cpumask Marcelo Tosatti
2022-01-21 18:16 ` Sebastian Andrzej Siewior
2022-01-24 12:58 ` Marcelo Tosatti
2022-01-24 16:26 ` Sebastian Andrzej Siewior
2022-01-24 16:40 ` Marcelo Tosatti
2022-01-24 16:44 ` Marcelo Tosatti
2022-01-24 17:07 ` Sebastian Andrzej Siewior
2022-01-24 17:50 ` Marcelo Tosatti
2022-01-25 18:40 ` [PATCH] rt-numa: ignore runtime cpumask if -a CPULIST is specified Marcelo Tosatti
2022-01-25 18:46 ` [PATCH v2] " Marcelo Tosatti
2022-01-26 7:21 ` Sebastian Andrzej Siewior
2022-01-28 17:44 ` John Kacur
2022-01-28 18:17 ` Sebastian Andrzej Siewior
2022-01-28 21:08 ` John Kacur
2022-01-28 18:39 ` [PATCH v3] " Marcelo Tosatti
2022-01-28 21:11 ` John Kacur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18abab1-c454-bd62-ebab-6b5451ac3de@redhat.com \
--to=jkacur@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=linux-rt-users@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox