From: Paul Jackson <pj@sgi.com>
To: "Paul Menage" <menage@google.com>
Cc: rostedt@goodmis.org, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, mingo@elte.hu,
dmitry.adamushko@gmail.com, ghaskins@novell.com,
a.p.zijlstra@chello.nl
Subject: Re: [PATCH -v2 4/7] RT overloaded runqueues accounting
Date: Mon, 22 Oct 2007 23:19:25 -0700 [thread overview]
Message-ID: <20071022231925.2b996db8.pj@sgi.com> (raw)
In-Reply-To: <6599ad830710222311x402c3d1agcc458742fb5e219c@mail.gmail.com>
Paul M wrote:
> Cgroups doesn't change the locking rules for accessing a cpuset from a
> task - you have to have one of:
Good - could you comment task_cs() with this explanation?
The rules are derived from the cpuset rules, as you explain,
and as I suspected, but now task_cs() is the most popular
way to access a tasks cpuset from code within kernel/cpuset.c,
and that's code you added.
The reason that I started this subthread is that I didn't see
any immediate evidence that the RT code was honoring this locking,
and I suspected that I clear comment over task_cs() could have
clarified that for them.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
next prev parent reply other threads:[~2007-10-23 6:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 2:59 [PATCH -v2 0/7] New RT Task Balancing -v2 Steven Rostedt
2007-10-23 2:59 ` [PATCH -v2 1/7] Add rt_nr_running accounting Steven Rostedt
2007-10-23 2:59 ` [PATCH -v2 2/7] track highest prio queued on runqueue Steven Rostedt
2007-10-23 2:59 ` [PATCH -v2 3/7] push RT tasks Steven Rostedt
2007-10-23 2:59 ` [PATCH -v2 4/7] RT overloaded runqueues accounting Steven Rostedt
2007-10-23 4:17 ` Paul Jackson
2007-10-23 6:11 ` Paul Menage
2007-10-23 6:19 ` Paul Jackson [this message]
2007-10-23 13:43 ` Steven Rostedt
2007-10-23 21:46 ` Paul Jackson
2008-01-29 13:00 ` Paul Jackson
2007-10-23 2:59 ` [PATCH -v2 5/7] pull RT tasks Steven Rostedt
2007-10-23 2:59 ` [PATCH -v2 6/7] wake up balance RT Steven Rostedt
2007-10-23 2:59 ` [PATCH -v2 7/7] disable CFS RT load balancing Steven Rostedt
2007-10-23 8:39 ` [PATCH -v2 0/7] New RT Task Balancing -v2 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071022231925.2b996db8.pj@sgi.com \
--to=pj@sgi.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=dmitry.adamushko@gmail.com \
--cc=ghaskins@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=menage@google.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).