From: Chirag Jog <chirag@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: "Timothy R. Chavez" <tim.chavez@linux.vnet.ibm.com>,
Nivedita Singhvi <niv@us.ibm.com>,
Josh Triplett <josht@linux.vnet.ibm.com>,
Sebastien Dugue <sebastien.dugue@bull.net>
Subject: [PATCH][RT][PPC64] Fix a previously reverted "fix"
Date: Thu, 10 Jul 2008 22:34:56 +0530 [thread overview]
Message-ID: <20080710170456.GB7685@linux.vnet.ibm.com> (raw)
This patch reintroduces a "fix" that got reverted.
Here was the original patch http://lkml.org/lkml/2007/5/22/133
Here is the new patch
This patch also fixes OOPS reported here: http://lkml.org/lkml/2008/6/19/146
>From tsutomu.owa@toshiba.co.jp
Signed-Off-By: Chirag <chirag@linux.vnet.ibm.com>
--- linux-2.6.25.8-rt7/arch/powerpc/kernel/entry_64.S 2008-07-10 16:37:17.000000000 +0000
+++ linux-2.6.25.8-rt7.mod/arch/powerpc/kernel/entry_64.S 2008-07-10 07:58:56.000000000 +0000
@@ -579,14 +579,9 @@ do_work:
cmpdi r0,0
crandc eq,cr1*4+eq,eq
bne restore
- /* here we are preempting the current task */
1:
- li r0,1
- stb r0,PACASOFTIRQEN(r13)
- stb r0,PACAHARDIRQEN(r13)
- ori r10,r10,MSR_EE
- mtmsrd r10,1 /* reenable interrupts */
- bl .preempt_schedule
+ /* preempt_schedule_irq() expects interrupts disabled. */
+ bl .preempt_schedule_irq
mfmsr r10
clrrdi r9,r1,THREAD_SHIFT
rldicl r10,r10,48,1 /* disable interrupts again */
next reply other threads:[~2008-07-10 17:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-10 17:04 Chirag Jog [this message]
2008-07-11 8:02 ` [PATCH][RT][PPC64] Fix a previously reverted "fix" Sebastien Dugue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080710170456.GB7685@linux.vnet.ibm.com \
--to=chirag@linux.vnet.ibm.com \
--cc=josht@linux.vnet.ibm.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=niv@us.ibm.com \
--cc=rostedt@goodmis.org \
--cc=sebastien.dugue@bull.net \
--cc=tim.chavez@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).