From: Dan Carpenter <error27@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
rt-users <linux-rt-users@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Clark Williams <williams@redhat.com>,
nando@ccrma.Stanford.EDU, Carsten Emde <ce@ceag.ch>
Subject: Re: [ANNOUNCE] 2.6.33-rc8-rt2
Date: Fri, 26 Feb 2010 22:44:36 +0300 [thread overview]
Message-ID: <20100226194436.GE8417@bicker> (raw)
In-Reply-To: <alpine.LFD.2.00.1002241740410.4245@localhost.localdomain>
kernel/trace/latency_hist.c
341 static ssize_t
342 latency_hist_reset(struct file *file, const char __user *a,
343 size_t size, loff_t *off)
344 {
345 int cpu;
346 struct hist_data *hist = NULL;
347 #if defined(CONFIG_WAKEUP_LATENCY_HIST) || \
348 defined(CONFIG_MISSED_TIMER_OFFSETS_HIST)
349 struct maxlatproc_data *mp = NULL;
350 #endif
351 off_t latency_type = (off_t) file->private_data;
352
353 for_each_online_cpu(cpu) {
354
355 switch (latency_type) {
It seems like this switch statement should have a default case.
I haven't looked into it very closely but it seems like if you had all
those config options turned off then "hist" would be still be NULL.
regards,
dan carpenter
next prev parent reply other threads:[~2010-02-26 19:44 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 16:52 [ANNOUNCE] 2.6.33-rc8-rt2 Thomas Gleixner
2010-02-24 22:38 ` Peter Zijlstra
2010-02-25 22:56 ` Peter Zijlstra
2010-02-26 19:44 ` Dan Carpenter [this message]
2010-02-27 8:10 ` Thomas Gleixner
2010-02-26 19:54 ` [ANNOUNCE] 2.6.33-rt3 Thomas Gleixner
2010-02-27 9:25 ` Xavier Miller
2010-02-27 10:10 ` GeunSik Lim
2010-02-27 11:53 ` Thomas Gleixner
2010-03-02 21:25 ` Fernando Lopez-Lezcano
2010-03-02 21:53 ` Thomas Gleixner
2010-02-27 9:50 ` GeunSik Lim
2010-03-12 10:44 ` [ANNOUNCE] 2.6.33-rt6 Thomas Gleixner
2010-03-12 12:17 ` 2.6.33-rt6 on Beagle Chatterjee, Amit
2010-03-15 9:20 ` Uwe Kleine-König
2010-03-15 11:23 ` What's the best way to create an embedded version of PREEMPT_RT Linux ? Armin Steinhoff
2010-03-21 11:06 ` [ANNOUNCE] 2.6.33.1-rt11 Thomas Gleixner
2010-04-07 14:24 ` [ANNOUNCE] 2.6.33.2-rt13 Thomas Gleixner
2010-04-27 15:52 ` [ANNOUNCE] 2.6.33.3-rt16 Thomas Gleixner
2010-04-30 10:00 ` [ANNOUNCE] 2.6.33.3-rt17 Thomas Gleixner
2010-05-02 19:18 ` [ANNOUNCE] 2.6.33.3-rt19 Thomas Gleixner
2010-06-09 16:44 ` [ANNOUNCE] 2.6.33.5-rt23 Thomas Gleixner
2010-06-09 21:31 ` Will Schmidt
2010-06-10 6:07 ` Thomas Gleixner
2010-06-10 15:56 ` Will Schmidt
2010-06-10 16:05 ` Darcy L. Watkins
2010-06-14 13:33 ` Thomas Gleixner
2010-06-14 13:34 ` Thomas Gleixner
2010-06-14 15:35 ` Will Schmidt
2010-07-13 15:54 ` [ANNOUNCE] 2.6.33.6-rt26 Thomas Gleixner
2010-07-13 16:52 ` Dhaval Giani
2010-07-13 18:04 ` Philipp Überbacher
2010-07-13 19:13 ` Darcy L. Watkins
2010-07-13 19:23 ` Philipp Überbacher
2010-07-14 13:47 ` Thomas Gleixner
2010-07-14 13:57 ` Ng Oon-Ee
2010-07-14 14:27 ` John Kacur
[not found] ` <AANLkTikRUp0IG8aMZ0eHxXcDmfUFTqW8HCSJcx8nQIZN@mail.gmail.com>
2010-07-15 5:25 ` Yang Jian
2010-07-15 11:45 ` Philipp Überbacher
2010-07-19 6:37 ` Barry Song
2010-07-31 13:33 ` [ANNOUNCE] 2.6.33.6-rt27 Thomas Gleixner
2010-08-03 9:23 ` [ANNOUNCE] 2.6.33.7-rt29 Thomas Gleixner
2010-12-21 13:52 ` Thomas Gleixner
2010-12-21 15:01 ` Mark Knecht
2010-12-21 15:48 ` Madovsky
2010-12-21 16:39 ` Dennis Borgmann
2010-12-22 16:38 ` Madovsky
2010-12-22 20:20 ` Remy Bohmer
2010-12-24 22:36 ` Fernando Lopez-Lezcano
2010-12-31 19:56 ` Fernando Lopez-Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100226194436.GE8417@bicker \
--to=error27@gmail.com \
--cc=ce@ceag.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nando@ccrma.Stanford.EDU \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).