* [PATCH] rt-tests - allow build without NUMA @ 2011-09-23 19:26 Frank Rowand 2011-09-23 19:46 ` Uwe Kleine-König 0 siblings, 1 reply; 6+ messages in thread From: Frank Rowand @ 2011-09-23 19:26 UTC (permalink / raw) To: Clark Williams, linux-rt-users "NUMA=0 make" does not remove numa from the build. Fix. Signed-off-by: Frank Rowand <frank.rowand@am.sony.com> --- Makefile | 2 1 + 1 - 0 ! 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/Makefile =================================================================== --- a/Makefile +++ b/Makefile @@ -26,7 +26,7 @@ else CFLAGS += -O0 -g endif -ifdef NUMA +ifeq ($(NUMA),"1") CFLAGS += -DNUMA NUMA_LIBS = -lnuma endif ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rt-tests - allow build without NUMA 2011-09-23 19:26 [PATCH] rt-tests - allow build without NUMA Frank Rowand @ 2011-09-23 19:46 ` Uwe Kleine-König 2011-09-23 21:09 ` Clark Williams 0 siblings, 1 reply; 6+ messages in thread From: Uwe Kleine-König @ 2011-09-23 19:46 UTC (permalink / raw) To: Frank Rowand; +Cc: Clark Williams, linux-rt-users On Fri, Sep 23, 2011 at 12:26:03PM -0700, Frank Rowand wrote: > > > "NUMA=0 make" does not remove numa from the build. Fix. > > Signed-off-by: Frank Rowand <frank.rowand@am.sony.com> > --- > Makefile | 2 1 + 1 - 0 ! > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: b/Makefile > =================================================================== > --- a/Makefile > +++ b/Makefile > @@ -26,7 +26,7 @@ else > CFLAGS += -O0 -g > endif > > -ifdef NUMA > +ifeq ($(NUMA),"1") > CFLAGS += -DNUMA > NUMA_LIBS = -lnuma > endif can we please addionally get something like: machinetype = $(shell uname -m | sed -e s/i.86/i386;s/mips.*/mips/;s/ppc.*/powerpc) ifneq ($(filter x86_64 i386 ia64 mips powerpc,$(machinetype)),) NUMA = 1 endif instead of the unconditional NUMA=1 we currently have? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rt-tests - allow build without NUMA 2011-09-23 19:46 ` Uwe Kleine-König @ 2011-09-23 21:09 ` Clark Williams 2011-09-24 19:31 ` Uwe Kleine-König 2011-09-26 20:16 ` Frank Rowand 0 siblings, 2 replies; 6+ messages in thread From: Clark Williams @ 2011-09-23 21:09 UTC (permalink / raw) To: Uwe Kleine-König; +Cc: Frank Rowand, linux-rt-users [-- Attachment #1: Type: text/plain, Size: 830 bytes --] On Fri, 23 Sep 2011 21:46:32 +0200 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > On Fri, Sep 23, 2011 at 12:26:03PM -0700, Frank Rowand wrote: > > > > How about this? diff --git a/Makefile b/Makefile index 4f51154..4776391 100644 --- a/Makefile +++ b/Makefile @@ -14,7 +14,11 @@ bindir ?= $(prefix)/bin mandir ?= $(prefix)/share/man srcdir ?= $(prefix)/src -NUMA := 1 +machinetype = $(shell uname -m | \ + sed -e 's/i.86/i386/' -e 's/mips.*/mips/' -e 's/ppc.*/powerpc/') +ifneq ($(filter x86_64 i386 ia64 mips powerpc,$(machinetype)),) +NUMA := 1 +endif CFLAGS = -D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include @@ -26,7 +30,7 @@ else CFLAGS += -O0 -g endif -ifdef NUMA +ifeq ($(NUMA),1) CFLAGS += -DNUMA NUMA_LIBS = -lnuma endif [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] rt-tests - allow build without NUMA 2011-09-23 21:09 ` Clark Williams @ 2011-09-24 19:31 ` Uwe Kleine-König 2011-09-26 20:16 ` Frank Rowand 1 sibling, 0 replies; 6+ messages in thread From: Uwe Kleine-König @ 2011-09-24 19:31 UTC (permalink / raw) To: Clark Williams; +Cc: Frank Rowand, linux-rt-users On Fri, Sep 23, 2011 at 04:09:18PM -0500, Clark Williams wrote: > On Fri, 23 Sep 2011 21:46:32 +0200 > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > > On Fri, Sep 23, 2011 at 12:26:03PM -0700, Frank Rowand wrote: > > > > > > > > > How about this? > > diff --git a/Makefile b/Makefile > index 4f51154..4776391 100644 > --- a/Makefile > +++ b/Makefile > @@ -14,7 +14,11 @@ bindir ?= $(prefix)/bin > mandir ?= $(prefix)/share/man > srcdir ?= $(prefix)/src > > -NUMA := 1 > +machinetype = $(shell uname -m | \ > + sed -e 's/i.86/i386/' -e 's/mips.*/mips/' -e 's/ppc.*/powerpc/') > +ifneq ($(filter x86_64 i386 ia64 mips powerpc,$(machinetype)),) > +NUMA := 1 > +endif > > CFLAGS = -D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include > > @@ -26,7 +30,7 @@ else > CFLAGS += -O0 -g > endif > > -ifdef NUMA > +ifeq ($(NUMA),1) > CFLAGS += -DNUMA > NUMA_LIBS = -lnuma > endif Looks good. Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rt-tests - allow build without NUMA 2011-09-23 21:09 ` Clark Williams 2011-09-24 19:31 ` Uwe Kleine-König @ 2011-09-26 20:16 ` Frank Rowand 2011-09-26 20:25 ` Uwe Kleine-König 1 sibling, 1 reply; 6+ messages in thread From: Frank Rowand @ 2011-09-26 20:16 UTC (permalink / raw) To: Clark Williams Cc: Uwe Kleine-König, Rowand, Frank, linux-rt-users@vger.kernel.org On 09/23/11 14:09, Clark Williams wrote: > On Fri, 23 Sep 2011 21:46:32 +0200 > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > >> On Fri, Sep 23, 2011 at 12:26:03PM -0700, Frank Rowand wrote: >>> >>> > > > How about this? > > diff --git a/Makefile b/Makefile > index 4f51154..4776391 100644 > --- a/Makefile > +++ b/Makefile > @@ -14,7 +14,11 @@ bindir ?= $(prefix)/bin > mandir ?= $(prefix)/share/man > srcdir ?= $(prefix)/src > > -NUMA := 1 > +machinetype = $(shell uname -m | \ > + sed -e 's/i.86/i386/' -e 's/mips.*/mips/' -e 's/ppc.*/powerpc/') > +ifneq ($(filter x86_64 i386 ia64 mips powerpc,$(machinetype)),) > +NUMA := 1 > +endif > > CFLAGS = -D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include > > @@ -26,7 +30,7 @@ else > CFLAGS += -O0 -g > endif > > -ifdef NUMA > +ifeq ($(NUMA),1) > CFLAGS += -DNUMA > NUMA_LIBS = -lnuma > endif That works for me. The change from Uwe doesn't solve the NUMA issue for me because I cross-compile, but I am quite happy to type: make NUMA=0 CC="${CROSS_COMPILE}gcc" which does solve the NUMA issue for me. -Frank -- To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rt-tests - allow build without NUMA 2011-09-26 20:16 ` Frank Rowand @ 2011-09-26 20:25 ` Uwe Kleine-König 0 siblings, 0 replies; 6+ messages in thread From: Uwe Kleine-König @ 2011-09-26 20:25 UTC (permalink / raw) To: Frank Rowand Cc: Clark Williams, Rowand, Frank, linux-rt-users@vger.kernel.org On Mon, Sep 26, 2011 at 01:16:19PM -0700, Frank Rowand wrote: > On 09/23/11 14:09, Clark Williams wrote: > > On Fri, 23 Sep 2011 21:46:32 +0200 > > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > > >> On Fri, Sep 23, 2011 at 12:26:03PM -0700, Frank Rowand wrote: > >>> > >>> > > > > > > How about this? > > > > diff --git a/Makefile b/Makefile > > index 4f51154..4776391 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -14,7 +14,11 @@ bindir ?= $(prefix)/bin > > mandir ?= $(prefix)/share/man > > srcdir ?= $(prefix)/src > > > > -NUMA := 1 > > +machinetype = $(shell uname -m | \ > > + sed -e 's/i.86/i386/' -e 's/mips.*/mips/' -e 's/ppc.*/powerpc/') > > +ifneq ($(filter x86_64 i386 ia64 mips powerpc,$(machinetype)),) > > +NUMA := 1 > > +endif > > > > CFLAGS = -D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include > > > > @@ -26,7 +30,7 @@ else > > CFLAGS += -O0 -g > > endif > > > > -ifdef NUMA > > +ifeq ($(NUMA),1) > > CFLAGS += -DNUMA > > NUMA_LIBS = -lnuma > > endif > > That works for me. > > The change from Uwe doesn't solve the NUMA issue for me because I > cross-compile, but I am quite happy to type: Yeah, my patch was meant on top of your's. So I get exactly what I wanted by Clark :-) Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-09-26 20:25 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-09-23 19:26 [PATCH] rt-tests - allow build without NUMA Frank Rowand 2011-09-23 19:46 ` Uwe Kleine-König 2011-09-23 21:09 ` Clark Williams 2011-09-24 19:31 ` Uwe Kleine-König 2011-09-26 20:16 ` Frank Rowand 2011-09-26 20:25 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).