From: Yong Zhang <yong.zhang0@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: Re: [RFC] [PATCH -rt 5/5] cpufreq: get rid of get_online_cpus()/put_online_cpus()
Date: Mon, 24 Oct 2011 19:30:56 +0800 [thread overview]
Message-ID: <20111024113056.GA2635@zhy> (raw)
In-Reply-To: <alpine.LFD.2.02.1110241123190.2642@ionos>
On Mon, Oct 24, 2011 at 11:24:51AM +0200, Thomas Gleixner wrote:
>
>
> On Mon, 24 Oct 2011, Yong Zhang wrote:
>
> > On Wed, Oct 19, 2011 at 11:12:20AM +0200, Thomas Gleixner wrote:
> > > On Sun, 16 Oct 2011, Yong Zhang wrote:
> > >
> > > > Fix below false positive (seems this is not a real deadlock scenario)
> > > > lockdep warning:
> > >
> > > This looks like you caused it with patch 1.
> >
> > Hmmm, yup.
> > CPU_DOWN_PREPARE will be under cpu_hotplug.lock.
> >
> > > Both need a bit more
> > > thought, but thanks for catching that.
> >
> > No sure whether it's big issue or not.
> > Mind showing more about your concern?
>
> This is probably not the only place which will run into that issue and
> I have not much interest to patch all those sites.
If so, I think that kind of violation has been caught in mainline,
because mainline has had CPU_DOWN_PREPARE called under
cpu_hotplug.lock, right?
Or am I missing something?
Thanks,
Yong
next prev parent reply other threads:[~2011-10-24 11:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-16 10:56 [RFC] [PATCH -rt 0/5] patchset focusing on cpu hotplug Yong Zhang
2011-10-16 10:56 ` [PATCH -rt 1/5] hotplug: sync_unplug: No '\n' in task name Yong Zhang
2011-10-16 10:56 ` [PATCH -rt 2/5] hotplug: Call cpu_unplug_begin() a little early Yong Zhang
2011-10-16 10:56 ` [RFC] [PATCH -rt 3/5] printk: don't call printk_tick in printk_needs_cpu() Yong Zhang
2011-10-16 10:56 ` [PATCH -rt 4/5] workqueue: hotplug fix Yong Zhang
2011-10-19 7:14 ` Thomas Gleixner
2011-10-24 2:26 ` Yong Zhang
2011-10-24 9:25 ` Thomas Gleixner
2011-10-16 10:56 ` [RFC] [PATCH -rt 5/5] cpufreq: get rid of get_online_cpus()/put_online_cpus() Yong Zhang
2011-10-19 9:12 ` Thomas Gleixner
2011-10-24 2:44 ` Yong Zhang
2011-10-24 9:24 ` Thomas Gleixner
2011-10-24 11:30 ` Yong Zhang [this message]
2011-10-24 11:45 ` Thomas Gleixner
2011-10-24 11:56 ` Yong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111024113056.GA2635@zhy \
--to=yong.zhang0@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).