From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yong Zhang Subject: Re: [RFC] [PATCH -rt 5/5] cpufreq: get rid of get_online_cpus()/put_online_cpus() Date: Mon, 24 Oct 2011 19:56:24 +0800 Message-ID: <20111024115624.GB2635@zhy> References: <1318762607-2261-1-git-send-email-yong.zhang0@gmail.com> <1318762607-2261-6-git-send-email-yong.zhang0@gmail.com> <20111024024416.GB24581@zhy> <20111024113056.GA2635@zhy> Reply-To: Yong Zhang Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org To: Thomas Gleixner Return-path: Received: from mail-pz0-f42.google.com ([209.85.210.42]:46498 "EHLO mail-pz0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754662Ab1JXL4p (ORCPT ); Mon, 24 Oct 2011 07:56:45 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-rt-users-owner@vger.kernel.org List-ID: On Mon, Oct 24, 2011 at 01:45:16PM +0200, Thomas Gleixner wrote: > On Mon, 24 Oct 2011, Yong Zhang wrote: > > On Mon, Oct 24, 2011 at 11:24:51AM +0200, Thomas Gleixner wrote: > > > > No sure whether it's big issue or not. > > > > Mind showing more about your concern? > > > > > > This is probably not the only place which will run into that issue and > > > I have not much interest to patch all those sites. > > > > If so, I think that kind of violation has been caught in mainline, > > because mainline has had CPU_DOWN_PREPARE called under > > cpu_hotplug.lock, right? > > > > Or am I missing something? > > Hmm, no. I obviously forgot that I moved it in RT :( > > So yes, it should be safe. Though the question is why cpufreq does not > suffer from that that problem in mainline. By this one: peter_zijlstra-fix-cpufreq.patch Thanks, Yong