From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>,
Edward Donovan <edward.donovan@numble.net>,
stable@kernel.org ("2.6.39+")
Subject: [PATCH RT 02/12 rc3] genirq: fix regression in irqfixup, irqpoll
Date: Mon, 05 Dec 2011 18:00:48 -0500 [thread overview]
Message-ID: <20111205230250.165366297@goodmis.org> (raw)
In-Reply-To: 20111205230046.736851081@goodmis.org
[-- Attachment #1: Type: text/plain, Size: 1582 bytes --]
From: Edward Donovan <edward.donovan@numble.net>
Commit fa27271bc8d2("genirq: Fixup poll handling") introduced a
regression that broke irqfixup/irqpoll for some hardware configurations.
Amidst reorganizing 'try_one_irq', that patch removed a test that
checked for 'action->handler' returning IRQ_HANDLED, before acting on
the interrupt. Restoring this test back returns the functionality lost
since 2.6.39. In the current set of tests, after 'action' is set, it
must precede '!action->next' to take effect.
With this and my previous patch to irq/spurious.c, c75d720fca8a, all
IRQ regressions that I have encountered are fixed.
Signed-off-by: Edward Donovan <edward.donovan@numble.net>
Reported-and-tested-by: Rogério Brito <rbrito@ime.usp.br>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@kernel.org (2.6.39+)
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---
kernel/irq/spurious.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c
index bfe1004..d09e0f5 100644
--- a/kernel/irq/spurious.c
+++ b/kernel/irq/spurious.c
@@ -84,7 +84,9 @@ static int try_one_irq(int irq, struct irq_desc *desc, bool force)
*/
action = desc->action;
if (!action || !(action->flags & IRQF_SHARED) ||
- (action->flags & __IRQF_TIMER) || !action->next)
+ (action->flags & __IRQF_TIMER) ||
+ (action->handler(irq, action->dev_id) == IRQ_HANDLED) ||
+ !action->next)
goto out;
/* Already running on another processor */
--
1.7.7.1
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-12-05 23:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 23:00 [PATCH RT 00/12 rc3] [ANNOUNCE] 3.0.12-rt30-rc3 Steven Rostedt
2011-12-05 23:00 ` [PATCH RT 01/12 rc3] tasklet/rt: Prevent tasklets from going into infinite spin in RT Steven Rostedt
2011-12-05 23:00 ` Steven Rostedt [this message]
2011-12-05 23:00 ` [PATCH RT 03/12 rc3] intel-iommu: Fix AB-BA lockdep report Steven Rostedt
2011-12-05 23:00 ` [PATCH RT 04/12 rc3] KVM: Sanitize cpuid Steven Rostedt
2011-12-05 23:00 ` [PATCH RT 05/12 rc3] KVM: fix XSAVE bit scanning (now properly) Steven Rostedt
2011-12-05 23:00 ` [PATCH RT 06/12 rc3] wait: Provide __wake_up_all_locked Steven Rostedt
2011-12-05 23:00 ` [PATCH RT 07/12 rc3] pci: Use __wake_up_all_locked pci_unblock_user_cfg_access() Steven Rostedt
2011-12-05 23:00 ` [PATCH RT 08/12 rc3] acpi: Make gbl_[hardware|gpe]_lock raw Steven Rostedt
2011-12-05 23:00 ` [PATCH RT 09/12 rc3] slab, lockdep: Fix silly bug Steven Rostedt
2011-12-05 23:00 ` [PATCH RT 10/12 rc3] slab, lockdep: Annotate all slab caches Steven Rostedt
2011-12-05 23:00 ` [PATCH RT 11/12 rc3] ACPI: Convert embedded controller lock to raw spinlock Steven Rostedt
2011-12-05 23:00 ` [PATCH RT 12/12 rc3] Linux v3.0.12-rt30-rc3 Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111205230250.165366297@goodmis.org \
--to=rostedt@goodmis.org \
--cc=C.Emde@osadl.org \
--cc=edward.donovan@numble.net \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).