From: Greg KH <gregkh@linuxfoundation.org>
To: Ivo Sieben <meltedpianoman@gmail.com>
Cc: linux-serial@vger.kernel.org, Alan Cox <alan@linux.intel.com>,
RT <linux-rt-users@vger.kernel.org>
Subject: Re: Deterministic behavior for TTY serial
Date: Fri, 4 May 2012 17:32:57 -0700 [thread overview]
Message-ID: <20120505003257.GA5169@kroah.com> (raw)
In-Reply-To: <CAMSQXEEnvpBoq7m5hMTtYObj4FsMAtUbpEaiftZ1CDmF56LZAQ@mail.gmail.com>
On Thu, May 03, 2012 at 05:28:47PM +0200, Ivo Sieben wrote:
> Hi,
>
> >
> > The PREEMPT_RT uses mutexes for "normal" spin locks that do not
> > disable interrupts...
> > I'll try to use raw spinlocks in this code section and for the tty flip buffer
> > See if that can solve my problem.
> >
> > If you have other ideas... let me know!
> >
> > Regards,
> > Ivo
>
> I've changed some small things to the tty layer (see my other 3 RFC
> patches I've send).
> Performance increased with my loopback stress test:
> - Old situation: average read call last for 50us, with peaks up to 230 us
> - New situation: average read call still 50us, peak up to 60 us
> - Write was stable in both situations: average of 90 us, peak up to 100 us
>
> Only the very first read & write took extra time (128 us for read, 143
> for write)
> I'm still investigating that...
>
> Feedback is very appreciated.
Why are raw spinlocks "faster" here? I like the end-result of what you
have accomplished, but I had some questions on your patches, care to
answer them?
thanks,
greg k-h
next prev parent reply other threads:[~2012-05-05 0:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 14:38 Deterministic behavior for TTY serial Ivo Sieben
2012-04-19 0:14 ` Greg KH
2012-04-19 15:37 ` Ivo Sieben
2012-04-19 15:46 ` Greg KH
2012-04-26 14:27 ` Ivo Sieben
2012-05-01 14:30 ` Ivo Sieben
2012-05-01 15:04 ` Alan Cox
[not found] ` <CAMSQXEHAyPOF6YghsYmqqyx+N0oMgn5E=znhgFyspMUnaH78ig@mail.gmail.com>
2012-05-02 8:38 ` Ivo Sieben
2012-05-02 12:39 ` Ivo Sieben
2012-05-03 15:28 ` Ivo Sieben
2012-05-05 0:32 ` Greg KH [this message]
2012-04-19 11:19 ` Alan Cox
2012-04-19 15:42 ` Ivo Sieben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120505003257.GA5169@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=meltedpianoman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).