From: Greg KH <gregkh@linuxfoundation.org>
To: Ivo Sieben <meltedpianoman@gmail.com>
Cc: linux-serial@vger.kernel.org, RT <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH-v2] tty: Use raw spin lock to protect the TTY read section
Date: Fri, 25 Jan 2013 08:13:51 -0800 [thread overview]
Message-ID: <20130125161351.GA9929@kroah.com> (raw)
In-Reply-To: <1359023699-27050-1-git-send-email-meltedpianoman@gmail.com>
On Thu, Jan 24, 2013 at 11:34:59AM +0100, Ivo Sieben wrote:
> The "normal" spin lock that guards the N_TTY line discipline read section
> is replaced by a raw spin lock.
>
> On a PREEMP_RT system this prevents unwanted scheduling overhead when data is
> read at the same time as data is being received: while RX IRQ threaded handling
> is busy a TTY read call is performed from a RT priority > threaded IRQ priority.
> The read call tries to take the read section spin lock (held by the threaded
> IRQ) which blocks and causes a context switch to/from the threaded IRQ handler
> until the spin lock is unlocked.
>
> On a 240 MHz AT91SAM9261 processor setup this fixes about 100us of scheduling
> overhead on the TTY read call.
Out of how many us total?
And this really makes a difference? I'd like to hear the rt developers
opinoin of this.
> Signed-off-by: Ivo Sieben <meltedpianoman@gmail.com
Forgot the trailing '>' :)
thanks,
greg k-h
next prev parent reply other threads:[~2013-01-25 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 14:09 [PATCH] tty: Use raw spin lock to protect the TTY read section Ivo Sieben
2013-01-24 10:34 ` [PATCH-v2] " Ivo Sieben
2013-01-25 16:13 ` Greg KH [this message]
2013-01-28 12:15 ` Ivo Sieben
2013-01-28 12:32 ` [PATCH-v3] " Ivo Sieben
2013-02-04 15:33 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125161351.GA9929@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=meltedpianoman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).