From: Tejun Heo <tj@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linaro-kernel@lists.linaro.org, patches@linaro.org,
robin.randhawa@arm.com, Steve.Bannister@arm.com,
Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com,
arvind.chauhan@arm.com, davem@davemloft.net, airlied@redhat.com,
axboe@kernel.dk, tglx@linutronix.de, peterz@infradead.org,
mingo@redhat.com, rostedt@goodmis.org,
linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 3/4] block: queue work on unbound wq
Date: Wed, 3 Apr 2013 14:54:12 -0700 [thread overview]
Message-ID: <20130403215412.GG3411@htj.dyndns.org> (raw)
In-Reply-To: <CAKohpo=nWsUh5y7y_tacGez7uN76QbRFRVPSQcKQMGM1nUBWtw@mail.gmail.com>
Hello, Viresh.
Sorry about the delay. Lost this one somehow.
On Mon, Apr 01, 2013 at 12:01:05PM +0530, Viresh Kumar wrote:
> Just wanted to make this clear before writing it:
>
> You want me to do something like (With better names):
>
> int wq_unbound_for_power_save_enabled = 0;
>
> #ifdef CONFIG_WQ_UNBOUND_FOR_POWER_SAVE
> #define WQ_UNBOUND_FOR_POWER_SAVE wq_unbound_for_power_save_enabled
> #else
> #define WQ_UNBOUND_FOR_POWER_SAVE 0
>
> And provide a call to enable/disable wq_unbound_for_power_save_enabled ??
Not a call, probably a module_param() so that it can be switched
on/off during boot. You can make the param writable so that it can be
flipped run-time but updating existing workqueues would be non-trivial
and I don't think it's gonna be worthwhile.
Thanks!
--
tejun
next prev parent reply other threads:[~2013-04-03 21:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-31 14:31 [PATCH V4 0/4] Queue work on UNBOUND wq Viresh Kumar
2013-03-31 14:31 ` [PATCH V4 1/4] workqueue: Add system wide system_freezable_unbound_wq Viresh Kumar
2013-04-01 5:20 ` Amit Kucheria
2013-04-01 5:25 ` Viresh Kumar
2013-04-08 16:59 ` Steven Rostedt
2013-04-09 4:11 ` Viresh Kumar
2013-03-31 14:31 ` [PATCH V4 2/4] PHYLIB: queue work on unbound wq Viresh Kumar
2013-03-31 16:45 ` David Miller
2013-03-31 14:31 ` [PATCH V4 3/4] block: " Viresh Kumar
2013-03-31 18:19 ` Tejun Heo
2013-04-01 6:31 ` Viresh Kumar
2013-04-03 21:54 ` Tejun Heo [this message]
2013-04-05 9:47 ` Viresh Kumar
2013-04-05 12:22 ` Tejun Heo
2013-04-08 10:24 ` Viresh Kumar
2013-04-08 10:37 ` Amit Kucheria
2013-04-08 11:02 ` Viresh Kumar
2013-04-08 11:13 ` Jens Axboe
2013-04-08 11:14 ` Viresh Kumar
2013-04-09 7:30 ` Viresh Kumar
2013-04-09 9:18 ` Amit Kucheria
2013-04-09 9:35 ` Viresh Kumar
2013-04-09 9:53 ` Amit Kucheria
2013-04-09 9:55 ` Viresh Kumar
2013-04-09 9:58 ` Amit Kucheria
2013-04-09 10:11 ` Viresh Kumar
2013-04-09 18:30 ` Tejun Heo
2013-04-22 6:20 ` Viresh Kumar
2013-04-23 20:24 ` Tejun Heo
2013-03-31 14:31 ` [PATCH V4 4/4] fbcon: " Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130403215412.GG3411@htj.dyndns.org \
--to=tj@kernel.org \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=airlied@redhat.com \
--cc=arvind.chauhan@arm.com \
--cc=axboe@kernel.dk \
--cc=charles.garcia-tobin@arm.com \
--cc=davem@davemloft.net \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=patches@linaro.org \
--cc=peterz@infradead.org \
--cc=robin.randhawa@arm.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).