* [PATCH] powerpc/64bit,PREEMPT_RT: Check preempt_count before preempting
@ 2013-04-15 5:48 Priyanka Jain
2013-04-25 16:58 ` Sebastian Andrzej Siewior
0 siblings, 1 reply; 5+ messages in thread
From: Priyanka Jain @ 2013-04-15 5:48 UTC (permalink / raw)
To: linux-rt-users; +Cc: Priyanka Jain
In ret_from_except_lite() with CONFIG_PREEMPT enabled,
add the missing check to compare value of preempt_count
with zero before continuing with preemption process of
the current task.
If preempt_count is non-zero, restore reg and return,
else continue the preemption process.
Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
---
arch/powerpc/kernel/entry_64.S | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S
index 1b1c8ae..ec120e6 100644
--- a/arch/powerpc/kernel/entry_64.S
+++ b/arch/powerpc/kernel/entry_64.S
@@ -643,6 +643,8 @@ resume_kernel:
#ifdef CONFIG_PREEMPT
/* Check if we need to preempt */
lwz r8,TI_PREEMPT(r9)
+ cmpwi 0,r8,0 /* if non-zero, just restore regs and return */
+ bne restore
andi. r0,r4,_TIF_NEED_RESCHED
bne+ check_count
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/64bit,PREEMPT_RT: Check preempt_count before preempting
2013-04-15 5:48 [PATCH] powerpc/64bit,PREEMPT_RT: Check preempt_count before preempting Priyanka Jain
@ 2013-04-25 16:58 ` Sebastian Andrzej Siewior
2013-04-26 4:01 ` Jain Priyanka-B32167
0 siblings, 1 reply; 5+ messages in thread
From: Sebastian Andrzej Siewior @ 2013-04-25 16:58 UTC (permalink / raw)
To: Priyanka Jain; +Cc: linux-rt-users, rostedt
* Priyanka Jain | 2013-04-15 11:18:16 [+0530]:
>Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
>---
> arch/powerpc/kernel/entry_64.S | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S
>index 1b1c8ae..ec120e6 100644
>--- a/arch/powerpc/kernel/entry_64.S
>+++ b/arch/powerpc/kernel/entry_64.S
>@@ -643,6 +643,8 @@ resume_kernel:
> #ifdef CONFIG_PREEMPT
> /* Check if we need to preempt */
> lwz r8,TI_PREEMPT(r9)
>+ cmpwi 0,r8,0 /* if non-zero, just restore regs and return */
>+ bne restore
> andi. r0,r4,_TIF_NEED_RESCHED
> bne+ check_count
Oh boy oh boy. Thanks for caching this. Steven please take this to v3.6,
don't see this chunk in v3.4.
Priyanka: does 64bit power work fine on v3.6/v3.8 besides this?
Sebastian
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] powerpc/64bit,PREEMPT_RT: Check preempt_count before preempting
2013-04-25 16:58 ` Sebastian Andrzej Siewior
@ 2013-04-26 4:01 ` Jain Priyanka-B32167
0 siblings, 0 replies; 5+ messages in thread
From: Jain Priyanka-B32167 @ 2013-04-26 4:01 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: linux-rt-users@vger.kernel.org, rostedt@goodmis.org
Hi,
I am working on v3.8 for 64-bit powerpc.
I have seen no other issue so far.
Able to boot Linux, run IPV4-fwd traffic. Currently running some stress test cases.
Regards
Priyanka
> -----Original Message-----
> From: Sebastian Andrzej Siewior [mailto:bigeasy@linutronix.de]
> Sent: Thursday, April 25, 2013 10:28 PM
> To: Jain Priyanka-B32167
> Cc: linux-rt-users@vger.kernel.org; rostedt@goodmis.org
> Subject: Re: [PATCH] powerpc/64bit,PREEMPT_RT: Check preempt_count before
> preempting
>
> * Priyanka Jain | 2013-04-15 11:18:16 [+0530]:
>
> >Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
> >---
> > arch/powerpc/kernel/entry_64.S | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> >diff --git a/arch/powerpc/kernel/entry_64.S
> >b/arch/powerpc/kernel/entry_64.S index 1b1c8ae..ec120e6 100644
> >--- a/arch/powerpc/kernel/entry_64.S
> >+++ b/arch/powerpc/kernel/entry_64.S
> >@@ -643,6 +643,8 @@ resume_kernel:
> > #ifdef CONFIG_PREEMPT
> > /* Check if we need to preempt */
> > lwz r8,TI_PREEMPT(r9)
> >+ cmpwi 0,r8,0 /* if non-zero, just restore regs and
> return */
> >+ bne restore
> > andi. r0,r4,_TIF_NEED_RESCHED
> > bne+ check_count
>
> Oh boy oh boy. Thanks for caching this. Steven please take this to v3.6,
> don't see this chunk in v3.4.
>
> Priyanka: does 64bit power work fine on v3.6/v3.8 besides this?
>
> Sebastian
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] powerpc/64bit,PREEMPT_RT: Check preempt_count before preempting
@ 2013-04-15 5:47 Priyanka Jain
2013-04-15 5:50 ` Jain Priyanka-B32167
0 siblings, 1 reply; 5+ messages in thread
From: Priyanka Jain @ 2013-04-15 5:47 UTC (permalink / raw)
To: linux-rt-users; +Cc: Priyanka Jain
In ret_from_except_lite() with CONFIG_PREEMPT enabled,
add the missing check to compare value of preempt_count
with zero before continuing with preemption process of
the current task.
If preempt_count is non-zero, restore reg and return,
else continue the preemption process.
Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
Fixes CQ:ENGR257848
CONFIG_PREEMPT_RT_FULL does not work on 64-bit
---
arch/powerpc/kernel/entry_64.S | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S
index 1b1c8ae..ec120e6 100644
--- a/arch/powerpc/kernel/entry_64.S
+++ b/arch/powerpc/kernel/entry_64.S
@@ -643,6 +643,8 @@ resume_kernel:
#ifdef CONFIG_PREEMPT
/* Check if we need to preempt */
lwz r8,TI_PREEMPT(r9)
+ cmpwi 0,r8,0 /* if non-zero, just restore regs and return */
+ bne restore
andi. r0,r4,_TIF_NEED_RESCHED
bne+ check_count
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH] powerpc/64bit,PREEMPT_RT: Check preempt_count before preempting
2013-04-15 5:47 Priyanka Jain
@ 2013-04-15 5:50 ` Jain Priyanka-B32167
0 siblings, 0 replies; 5+ messages in thread
From: Jain Priyanka-B32167 @ 2013-04-15 5:50 UTC (permalink / raw)
To: Jain Priyanka-B32167, linux-rt-users@vger.kernel.org
Please ignore this patch. I have send another patch with updated description.
> -----Original Message-----
> From: Jain Priyanka-B32167
> Sent: Monday, April 15, 2013 11:17 AM
> To: linux-rt-users@vger.kernel.org
> Cc: Jain Priyanka-B32167
> Subject: [PATCH] powerpc/64bit,PREEMPT_RT: Check preempt_count before
> preempting
>
> In ret_from_except_lite() with CONFIG_PREEMPT enabled, add the missing
> check to compare value of preempt_count with zero before continuing with
> preemption process of the current task.
> If preempt_count is non-zero, restore reg and return, else continue the
> preemption process.
>
> Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com> Fixes
> CQ:ENGR257848
> CONFIG_PREEMPT_RT_FULL does not work on 64-bit
> ---
> arch/powerpc/kernel/entry_64.S | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/kernel/entry_64.S
> b/arch/powerpc/kernel/entry_64.S index 1b1c8ae..ec120e6 100644
> --- a/arch/powerpc/kernel/entry_64.S
> +++ b/arch/powerpc/kernel/entry_64.S
> @@ -643,6 +643,8 @@ resume_kernel:
> #ifdef CONFIG_PREEMPT
> /* Check if we need to preempt */
> lwz r8,TI_PREEMPT(r9)
> + cmpwi 0,r8,0 /* if non-zero, just restore regs and
> return */
> + bne restore
> andi. r0,r4,_TIF_NEED_RESCHED
> bne+ check_count
>
> --
> 1.7.4.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-04-26 4:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-15 5:48 [PATCH] powerpc/64bit,PREEMPT_RT: Check preempt_count before preempting Priyanka Jain
2013-04-25 16:58 ` Sebastian Andrzej Siewior
2013-04-26 4:01 ` Jain Priyanka-B32167
-- strict thread matches above, loose matches on Subject: below --
2013-04-15 5:47 Priyanka Jain
2013-04-15 5:50 ` Jain Priyanka-B32167
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox